[Bug] Compilation fails with gdal 3.3.0 because ogr_srs_api.h is not found

[ggardet]

Describe the bug
ogr_srs_api.h is not found with gdal 3.3.0. It was fine with gdal 3.2.3. This file is available under /usr/include/gdal.
Error log:

[  255s] GISRC=/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/demolocation/.grassrc78 GISBASE=/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu PATH="/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/bin:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/bin:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/scripts:$PATH" PYTHONPATH="/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/etc/python:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/gui/wxpython:$PYTHONPATH" LD_LIBRARY_PATH="/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/bin:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/bin:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/scripts:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/lib:/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/lib:" LC_ALL=C LANG=C LANGUAGE=C ./ctypesgen.py --cpp "gcc -E   ""     -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG" -lgrass_imagery.7.8   /home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include/grass/imagery.h /home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include/grass/defs/imagery.h -o OBJ.aarch64-unknown-linux-gnu/imagery.py
[  255s] Status: Preprocessing /tmp/tmpdgg74w2b.h
[  255s] Status: gcc -E        -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG -U __GNUC__ -dD "-Dinline=" "-D__inline__=" "-D__extension__=" "-D_Bool=uint8_t" "-D__const=const" "-D__asm__(x)=" "-D__asm(x)=" "-DCTYPESGEN=1" "/tmp/tmpdgg74w2b.h"
[  255s] Error: gcc -E        -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG: In file included from /tmp/tmpdgg74w2b.h:1:
[  255s] Error: gcc -E        -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG: /home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include/grass/gprojects.h:32:14: fatal error: ogr_srs_api.h: No such file or directory
[  255s] Error: gcc -E        -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG:    32 | #    include <ogr_srs_api.h>
[  255s] Error: gcc -E        -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG:       |              ^~~~~~~~~~~~~~~
[  255s] Error: gcc -E        -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -I/home/abuild/rpmbuild/BUILD/grass-7.8.5/dist.aarch64-unknown-linux-gnu/include -D__GLIBC_HAVE_LONG_LONG: compilation terminated.

To Reproduce
Try to build against gdal 3.3.0

Expected behavior
Compilation should pass.

Screenshots
N/A

System description (please complete the following information):

• Operating System: Linux, openSUSE Tumbleweed
• GRASS GIS version: 7.8.5

Additional context

[tigerfoot]

@rouault this is not a regression in gdal right, like missing during install ?
I saw the file in source tar.xz

[rouault]

@rouault this is not a regression in gdal right, like missing during install ?

no, ogr_srs_api.h is still installed by make install

[tigerfoot]

@rouault this is not a regression in gdal right, like missing during install ?

no, ogr_srs_api.h is still installed by make install
Ok thanks for the quick reply, I rechecked and its there as expected ... in
/usr/include/gdal/ogr_srs_api.h

[nilason]

This is probably the same issue as reported with #1563, fixed with #1567 for master and 7.8.6.

[nilason]

The error log extract quoted above is not the cause of the compilation failure. This is from the ctypesgen parsing which is cluttered with "false" error warnings.

[tigerfoot]

The error log extract quoted above is not the cause of the compilation failure. This is from the ctypesgen parsing which is cluttered with "false" error warnings.

I agree at least on x86_64 we have error in v-hull as you cited #1563
see
build error x86_64
Unfortunately arm is scheduled to be rebuild ...
https://build.opensuse.org/package/show/Application:Geo/grass

So clearly we will apply the patch, or 7.8.6 is about to be published in the next 48hours ?

[nilason]

It is very soon to be released I guess but perhaps not within 48 hrs.
See https://github.com/macports/macports-ports/blob/master/gis/grass7/files/patch-bool-fix.diff for a small temporary fix.

[tigerfoot]

Ok I used to pick direct commit (easier to maintain on OBS for OpenSUSE spec file)
https://github.com/OSGeo/grass/commit/b86314c7.patch

I'm testing a local build, and if ok submit fixes directly there.
@nilason thanks for your quick and efficient help!

If everything build fine until tomorrow we (me or @ggardet ) will close this issue.

[tigerfoot]

Ok perfect with that patch every plateform build correctly. So closing.

[nilason]

Ok perfect with that patch every plateform build correctly. So closing.

Great!

[nilason]

Closing this, please reopen if needed.