Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up rules for managing PRs #3235

Open
landam opened this issue Nov 10, 2023 · 1 comment
Open

Set up rules for managing PRs #3235

landam opened this issue Nov 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@landam
Copy link
Member

landam commented Nov 10, 2023

Currently we have a large number of open PR which are in different shape (approved, commented, change requested, no feedback).

image

Let's improve this situation by setting up rules, which help us to manage PRs. See few points below to open discussion:

  • no changes requested from reviewers + tests passed -> PR will be merged by assignee
  • every PR must have assignee who is responsible for merging or closing
    • PRs reported by member with write access will be automatically assigned to reporter
    • PRs reported by member without write access will be assigned based on topic / first label (assignee may be reassigned (no time, limited expertise) to someone else)
@nilason
Copy link
Contributor

nilason commented Nov 21, 2023

I'm glad this issue is up to discussion. As a committer I have (too often) experienced what is really sticking out in the statistics you provide: "No feedback" – ending up more often than not to put up an "ultimatum" ("If there are no objections....") to move things forward. That I only do, however, when I have absolutely no doubts myself on the PR in question, but I'd prefer to have some level of feedback.
I'm quite certain that this situation – in general – is not a sign of lack of enthusiasm, but of time available to dedicate to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants