Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Map failed" when attempting to view specific changeset #615

Open
ZLima12 opened this issue Mar 26, 2022 · 2 comments
Open

"Map failed" when attempting to view specific changeset #615

ZLima12 opened this issue Mar 26, 2022 · 2 comments

Comments

@ZLima12
Copy link

ZLima12 commented Mar 26, 2022

I'm submitting a (bug report/feature request/ support or question)

Bug Report

Brief Description

When I attempt to view changeset 118466153, the map never loads, and I get an error saying:

Changeset:118466153 Map failed
Please reload the application. If it still doesnt work please refer to usage guide.

Reloading does nothing. I asked in the general channel of the OSMUS Slack, and 5 other people said they encountered the same issue.

What is the current behaviour, (attach relevant screenshots) ?

See description. Additionally, see this screenshot.

What is the expected behaviour ?

For the changeset to load normally.

When does this occur ?

Any time you try to load the changeset.

How do we replicate the issue ?

  1. Open the changeset

Please tell us about your environment:

Linux x86_64, Firefox 98.0.2

Other Information / context:

None.

@mmd-osm
Copy link

mmd-osm commented Apr 18, 2022

https://github.com/osmlab/changeset-map/blob/master/lib/getChangeset.js#L93 -
features[1] is undefined in this case.

@nrenner
Copy link

nrenner commented Mar 8, 2024

  1. real-changesets-parser returns undefined instead of a feature when a way has no nodes (element.js#L27-L30):
     function createWay(data) {
       if (data.nodes.length === 0) {
         return;
       }
    (the GeoJSON spec would allow coordinates to be empty (3.1) or the geometry property to be null (3.2))
  2. The old entry for way 199760894 has no details in the adiff query response:
    <action type="modify">
    <old>
      <way id="199760894" version="6" timestamp="2021-01-15T17:20:21Z" changeset="97574667" ... />
    </old>
    <new>
      <way id="199760894" version="6" timestamp="2021-01-15T17:20:21Z" changeset="97574667" ... >
        <bounds minlat="41.2845186" minlon="-73.7716790" maxlat="41.2846432" maxlon="-73.7715706"/>
        <nd ref="2097537190" lat="41.2845186" lon="-73.7716790"/>
        <nd ref="373645825" lat="41.2846432" lon="-73.7715706"/>
        <tag k="foot" v="yes"/>
        ...
  3. Propably because it's considered being outside of the bbox, as the old version of the moved end node 373645825 is right on the bbox:

What would be expected here is to also show the geometry of the old way segment. Which could maybe be reconstructed from the data we get.

But as this is yet another issue with querying changesets from Overpass, I would rather suggest to investigate in searching and building an alternative solution (#652).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants