Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZFP: Move computing of Sv offset outside of setting of Vendors and test for Sv offset using ASL/Rutgers Data #1305

Open
2 of 3 tasks
ctuguinay opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
enhancement This makes echopype better
Milestone

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Apr 17, 2024

  • Create the Sv_offset dataset in the AZFP parser and pack it in parser_obj.unpacked_data
  • Make the error message in the Sv offset frequency check more specific (Wu-Jung posted below)
  • When ASL/Rutgers AZFP data arrives, write tests for skipped tests from Update _calc_Sv_offset for AZFP parsing #1304
@ctuguinay ctuguinay self-assigned this Apr 17, 2024
@ctuguinay ctuguinay added this to the v0.8.4 milestone Apr 17, 2024
@ctuguinay ctuguinay added the enhancement This makes echopype better label Apr 17, 2024
@leewujung
Copy link
Member

Just realized that the error message can be more specific to add the freq for the second check, so maybe we include that in this next PR also:

        # Check if the specified freq-pulse length combination is in the allowable Sv_offset dict
        if pulse_len not in SV_OFFSET[freq]:
            raise ValueError(
                f"Pulse length {pulse_len} us is not in the Sv offset dictionary "
                "for the {freq} Hz channel! "  # add freq info
                "Please contact AZFP Environmental Sciences "
                "and raise an issue in the echopype repository."
            )

@ctuguinay
Copy link
Collaborator Author

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This makes echopype better
Projects
Status: No status
Development

No branches or pull requests

2 participants