Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize MVBS computation #662

Closed
leewujung opened this issue May 4, 2022 · 1 comment
Closed

Generalize MVBS computation #662

leewujung opened this issue May 4, 2022 · 1 comment
Labels
enhancement This makes echopype better
Milestone
0.6.4

Comments

@leewujung
Copy link
Member

leewujung commented May 4, 2022 •
edited

The operation in compute_MVBS is basically to compute a 2D binned average of Sv along echo_range and ping_time. Note that the average should be done in the linear domain (sV) and converted back to the log domain (SV).

Currently error is raised when echo_range is different across ping_time, so that we can force the output echo_range to be the same for all pings. We should generalize it to compute this even if echo_range has different max value (related to the length of dimension range_sample) and step size (related to sample_interval).
@leewujung leewujung added the enhancement This makes echopype better label May 4, 2022
@leewujung leewujung mentioned this issue May 4, 2022
Merged
@leewujung leewujung added this to the 0.6.2 milestone Jun 15, 2022
@leewujung leewujung mentioned this issue Jun 23, 2022
Merged
3 tasks
@leewujung leewujung added the bug Something isn't working label Jun 29, 2022
@leewujung leewujung removed the bug Something isn't working label Jul 7, 2022
@leewujung leewujung modified the milestones: 0.6.2, 0.6.3 Jul 7, 2022
@leewujung leewujung mentioned this issue Oct 8, 2022
Closed
@leewujung leewujung modified the milestones: 0.6.3, 0.6.4 Oct 13, 2022
@b-reyes b-reyes mentioned this issue Nov 4, 2022
Merged
5 tasks
@leewujung
Copy link
Member Author

This is now addressed in #878.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This makes echopype better
Projects
Echopype
Status: Done
Milestone
0.6.4
Development

No branches or pull requests
1 participant
@leewujung