Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve env_params intake and add test #965

Closed
leewujung opened this issue Mar 9, 2023 · 1 comment
Closed

Improve env_params intake and add test #965

leewujung opened this issue Mar 9, 2023 · 1 comment
Assignees
@leewujung
Labels
enhancement This makes echopype better tests
Milestone
0.7.0

Comments

@leewujung
Copy link
Member

leewujung commented Mar 9, 2023 •
edited
Loading

This issue is to keep track of one of the remaining issues from #955:

  • improve env_params intake in a form similar to what we do with cal_params (eg have an overarching dict defining all allowable params)
  • add unit tests and integration tests that checked the intake of env_params into calibration objects.

Note: #955 contains these tests for cal_params intake, under test_cal_params.py and test_cal_params_integration.py
@leewujung leewujung added the tests label Mar 9, 2023
@leewujung leewujung added this to the 0.7.0 milestone Mar 9, 2023
@leewujung leewujung assigned leewujung and lsetiawan and unassigned leewujung Mar 9, 2023
@leewujung leewujung changed the title Add tests for env_param intake Improve env_param intake and add test Mar 9, 2023
@leewujung leewujung changed the title Improve env_param intake and add test Improve env_params intake and add test Mar 9, 2023
@leewujung leewujung assigned leewujung and unassigned lsetiawan Mar 14, 2023
@leewujung leewujung added the enhancement This makes echopype better label Mar 14, 2023
@leewujung leewujung modified the milestones: 0.7.0, 0.6.4.1 Mar 14, 2023
@leewujung leewujung changed the title Improve env_params intake and add test Improve env_params intake and add test, fix regression bug for EK60 env params intake Mar 14, 2023
@leewujung leewujung mentioned this issue Mar 14, 2023
Merged
@leewujung leewujung modified the milestones: 0.6.4.1, 0.7.0 Mar 16, 2023
@leewujung leewujung changed the title Improve env_params intake and add test, fix regression bug for EK60 env params intake Improve env_params intake and add test Mar 16, 2023
@leewujung
Copy link
Member Author

This is addressed in #985.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leewujung leewujung

Labels
enhancement This makes echopype better tests
Projects
Echopype
Status: Done
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@leewujung @lsetiawan