Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #23

Closed
abuhman opened this issue Feb 16, 2017 · 2 comments
Closed

Documentation #23

abuhman opened this issue Feb 16, 2017 · 2 comments

Comments

@abuhman
Copy link
Contributor

abuhman commented Feb 16, 2017

Good practices in documentation will help our code to be maintainable over the long run. It also allows for better teamwork and easier contribution from outside users.

  1. Comments. We should have comments explaining what each part of the code is doing and why. This helps both new contributors and ourselves to remember or understand the code. Comments also need to be kept up-to-date with the code, that way they match what is actually happening.

  2. Clean code. While when initially solving a problem we may end up with code that is messy and hard to read, we should strive to clean up the code such that it is as self-explanatory as possible. This includes but is not limited to intuitive variable names, good formatting, and refactoring (with tests) to make code easier to follow when necessary.

  3. Unit tests. While the main purpose of unit tests is to determine whether something is working and detect breaking changes, they can also be a form of documentation. If a unit test is complete, well-written, and up-to-date with the code it refers to, it shows the reader what are the expected results of running a particular piece of the code.

@sgoggins
Copy link
Member

sgoggins commented Oct 6, 2017

i think we are doing better at this, but it would be good to get a checkup at the end of the next release.

@sgoggins
Copy link
Member

This is in good shape now. We have 96% coverage for unit tests on metrics and fairly good coverage on everything else. This is fixed when we release the current dev branch to code.

Right now we need tests for libraries.io functions.

@howderek howderek moved this from In Progress to Done in Front End Developer Update Release 0.4.0 Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants