Formatting fixes

src/admin/models/sitemaps.php

@@ -12,7 +12,6 @@
 
 defined('_JEXEC') or die();
 
-
 class OSMapModelSitemaps extends JModelList
 {
     public function __construct($config = array())
@@ -60,8 +59,8 @@ protected function getListQuery()
             $query->where('sitemap.name LIKE ' . $db->quote('%' . $search . '%'));
         }
 
-        $ordering = $this->getState('list.ordering');
-        $direction   = $this->getState('list.direction');
+        $ordering  = $this->getState('list.ordering');
+        $direction = $this->getState('list.direction');
         $query->order($ordering . ' ' . $direction);
 
         return $query;
@@ -116,23 +115,23 @@ public function getItems()
     }
 
     /**
-     * Method to change the published state of one or more records.
-     *
-     * @param   array   &$pks  A list of the primary keys to change.
-     * @param   integer $value The value of the published state.
+     * Publish/Unpublish method
      *
-     * @return  boolean  True on success.
+     * @param int[] $pks
+     * @param int   $value
      *
-     * @since   12.2
+     * @return  bool
      */
-    public function publish(&$pks, $value = 1)
+    public function publish($pks, $value = 1)
     {
         $db = $this->getDbo();
 
+        $pks = array_filter(array_map('intval', $pks));
+
         $query = $db->getQuery(true)
             ->set('published = ' . $db->quote($value))
             ->update('#__osmap_sitemaps')
-            ->where('id IN (' . implode(',', $pks) . ')');
+            ->where(sprintf('id IN (%s)', join(',', $pks)));
 
         return $db->setQuery($query)->execute();
     }

src/admin/views/sitemaps/view.html.php

@@ -60,7 +60,7 @@ public function display($tpl = null)
         $this->filterForm    = $model->getFilterForm();
         $this->activeFilters = $model->getActiveFilters();
 
-        if (count($errors = $model->getErrors())) {
+        if ($errors = $model->getErrors()) {
             throw new Exception(implode("\n", $errors));
         }
 
@@ -176,5 +176,4 @@ protected function getLink($item, $type, $lang = null)
 
         return $router->routeURL('index.php?' . http_build_query($query));
     }
-
 }