Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 Universal Platform build compatibility #232

Open
demonixis opened this issue Jul 8, 2017 · 5 comments
Open

Windows 10 Universal Platform build compatibility #232

demonixis opened this issue Jul 8, 2017 · 5 comments

Comments

@demonixis
Copy link
Contributor

demonixis commented Jul 8, 2017

Hi,

OSVR is not yet compatible with the Windows 10 Universal Platform. This platform has a new API with some missing functions, such as DLLImport. It's a real problem for a lot of SDK so we just have to patch sources with

#if !UNITY_WSA
[DLLImport(SomFunction)]
public extern static SomeFunction();
#else
public static SomeFunction() { }
#endif

[I already patched and submited a pull request] on the ’Managed-OSVR’ repository, my work allows you to generate a placeholder DLL (which must be used in Unity by example).

For my game which is already compatible with the Vive, Rift and of course OSVR, I had to patch all the OSVR SDK. Today I want to know if you're interested by this work. It changes some files, but it changes no behaviours, or anything.

The first step could be to merge my work, but a second step could be to move all ’DLLImport’ into separate files to have the native call and the SDK separated.

If you're OK with that, I can update my repository last week.

@DuFF14
Copy link
Member

DuFF14 commented Jul 11, 2017

@demonixis Sounds like a good change. Are you going to open a PR for this repo? How would I be able to test this?
@JeroMiya should probably review the Managed-OSVR changes.

@demonixis
Copy link
Contributor Author

I can create a pull request last week, I'm just back from vacancy and I've an important update to push quicky.
I saw you're working on two branches (skeleton & android), do you want to merge these branches before my PR?

@DuFF14
Copy link
Member

DuFF14 commented Jul 18, 2017

go ahead and create a PR, I don't know if the other PRs will be merged this week or not.

@demonixis
Copy link
Contributor Author

Great, I prepare the PR today! The second step if you're OK this with could be to centralize all DLLImport into a native or a set of natives file(s). This way we can use an uniq #if !UNITY_WSA define. The same idea could be nice for Managed-OSVR.

I read that the Windows Mixed Reality HMD will be useable from the Unity Editor! I think that we can create a driver for OSVR as well. This could be awesome because for now, those HMD are limited to the Windows Store.

@demonixis
Copy link
Contributor Author

I just opened #233 with all changes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants