Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: enrich_data_sources is not working #57

Closed
Flockenmumie opened this issue Jun 9, 2022 · 3 comments
Closed

Bug: enrich_data_sources is not working #57

Flockenmumie opened this issue Jun 9, 2022 · 3 comments

Comments

@Flockenmumie
Copy link

Following this manual: https://attackcti.com/playground/1-Collect_All_Functions.html#enrich-techniques-data-sources

The following lines are not working ...

lift = attack_client()

def get_dataframe():
    enterprise = lift.get_techniques(enrich_data_sources=True)
    return None

... as the following error is generated:

[...]
enterprise = lift.get_techniques(enrich_data_sources=True)
  File "/home/user/.local/lib/python3.10/site-packages/attackcti/attack_api.py", line 943, in get_techniques
all_techniques = self.enrich_techniques_data_sources(all_techniques)
  File "/home/user/.local/lib/python3.10/site-packages/attackcti/attack_api.py", line 1760, in enrich_techniques_data_sources
    dc = dc_lookup[rl['source_ref']]
KeyError: 'x-mitre-data-component--4c12c1c8-bcef-4daf-8e5b-fca235f71d9e'
@ghost
Copy link

ghost commented Jul 1, 2022

I have the same error.

@Cyb3rWard0g
Copy link
Collaborator

Hello @Flockenmumie and @mihaid-b !

Sorry for the late reply. I can see ATT&CK is adding ICS data components to the framework. I do not remember that being announced as complete. I thought they were still working on it. The current version of this library only looks for Enterprise since ICS was not complete.

I am updating the library at the moment to get it to work.

@Cyb3rWard0g
Copy link
Collaborator

Ok version 0.3.7 now handles ICS data components :)

image

We can see the data sources and data components all together :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants