Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.3.1 implies that input validation is enough for security #1594

Closed
jmanico opened this issue Mar 28, 2023 · 3 comments
Closed

13.3.1 implies that input validation is enough for security #1594

jmanico opened this issue Mar 28, 2023 · 3 comments
Assignees
Labels

Comments

@jmanico
Copy link
Member

jmanico commented Mar 28, 2023

13.3.1 (also briefly mentioned here #1552) implies that input validation is enough to protect data.

13.3.1 Verify that XSD schema validation takes place to ensure a properly formed XML document, followed by validation of each input field before any processing of that data takes place. 20

Inputs into API's may need validation or possibly sanitization for HTML input, or even encoding in some cases to protect against injection, or query parameterization to protect from SQl. Even valid data can sometimes cause injection! Validation is not always "the way" and sometimes it does not secure data, such as a valid email can still be a SQLi vector like jim'or'!=@manicode.com

@elarlang
Copy link
Collaborator

elarlang commented Mar 29, 2023

English is not my native language so I'm not able to read from "validation of each input field before any processing of that data takes place" that it is "enough for security".

Taken SQL injection as an example, then this is not something what you can fix or defend on XML validation layer. With XSD schema validation you need to validate, that input XML is with expected structure and this is the first step of the input handling. The requirement does not limit it to be the only and/or last step.

Can you please redefine or rephrase the problem with the requirement 13.3.1?

@elarlang elarlang added the 2) Awaiting response Awaiting a response from the original poster label Mar 29, 2023
@elarlang elarlang removed their assignment Mar 30, 2023
@elarlang
Copy link
Collaborator

elarlang commented Apr 5, 2023

ping @jmanico

@jmanico
Copy link
Member Author

jmanico commented Jun 1, 2023

Fair argument, happy to close this out.

@elarlang elarlang closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants