Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT TO BE MERGED - JUST SHOWS DIFFERENCE from 4.0.2 to 4.0.3 #1104

Closed
wants to merge 60 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
5f72ad1
Start v4.0.3 with some small fixes and version tweaks
tghosth Feb 15, 2021
99f5d40
Add a new flat JSON format to the document generation script (#904)
tghosth Feb 18, 2021
65681f5
Add draft notice
tghosth Feb 18, 2021
5281bf0
Minor wording tweaks from @liamsmit
liamsmit Mar 17, 2021
632075b
Updated DE output for 4.0.2 (#949)
tghosth Mar 30, 2021
1c43051
Update DE PDF to be correct and DOCX with formatting
tghosth Apr 7, 2021
09cb232
Sync branches
tghosth Apr 21, 2021
9646268
Minor wording updates
tghosth Apr 21, 2021
b759de8
category renames based on #802
Apr 11, 2021
9492033
category rename based on #922
Apr 11, 2021
0800a32
Make several minor cosmetic changes
tghosth Apr 21, 2021
7352aa3
Removed 1.12.1 as per #1065
tghosth Oct 24, 2021
6b9ab22
v4.0.3-14.4.7 CWE update (#954)
Oct 25, 2021
d8d73b3
Deleted 1.4.2 as per #736
tghosth Oct 25, 2021
6f0b098
delete 1.4.3 (#877)
Oct 25, 2021
f272a42
update 2.1.2 description (#886)
Oct 25, 2021
f4378a2
update 2.3.2 description (#1053)
Oct 25, 2021
a551e0b
update 3.4.4 description (#986)
Oct 25, 2021
8b595f1
update 3.6.1 description (#1053)
Oct 25, 2021
9f1f36e
update 2.4.4 description (#1000)
Oct 25, 2021
8e1028c
deleted 4.1.4 (#1085)
Oct 25, 2021
bd3a2d3
update 5.1.4 description (#719)
Oct 25, 2021
3545b38
update 5.3.6 description (#1010)
Oct 25, 2021
f28dd74
update 7.3.1 description (#887, #1019)
Oct 25, 2021
3258c48
deleted 7.3.2 (#878)
Oct 25, 2021
e22b81b
update 8.2.2 description (#1091)
Oct 25, 2021
88b25d8
update 9.1.1 description (#770)
Oct 25, 2021
ef28ddf
update 9.1.2 description (#770)
Oct 25, 2021
7709403
update 9.1.3 description (#770)
Oct 25, 2021
635a67e
update 11.1.4 description (#971)
Oct 25, 2021
8987f36
update 12.1.2 description (#799)
Oct 25, 2021
27eaddf
update 12.4.1 description and cwe change (#1065)
Oct 25, 2021
b537c61
update 12.4.2 description (#679)
Oct 25, 2021
f39a965
deleted 13.1.2 description (#1028)
Oct 25, 2021
ba03e5e
deleted 13.2.4 description (#971)
Oct 25, 2021
fecadf7
update 14.2.2 description (#880)
Oct 25, 2021
5f2954d
update 14.2.5 description (#1066)
Oct 25, 2021
c1bddef
deleted 14.3.1 description (#881)
Oct 25, 2021
093ad09
update 14.4.1 description (#788)
Oct 25, 2021
76a78dd
update 14.4.6 description (#861)
Oct 25, 2021
48cc168
remove double spaces
Oct 25, 2021
c659930
update 3.4.5 description (#978)
Oct 25, 2021
26a520e
Merge pull request #1100 from elarlang/v4.0.3-14.4.7
jmanico Oct 25, 2021
2a6dbaf
Grammar fixes
tghosth Oct 26, 2021
f096364
Merge branch 'v4.0.3' into v4.0.3-sync-changes-from-bleeding-edge
tghosth Oct 26, 2021
71398cf
Merge pull request #1102 from elarlang/v4.0.3-sync-changes-from-bleed…
tghosth Oct 26, 2021
69ac139
Fix version numbers and contributors
tghosth Oct 26, 2021
36f0ca7
Updating other version numbers
tghosth Oct 26, 2021
e4ee077
Additional version updates
tghosth Oct 26, 2021
74ba5fe
Fixed pluralization
tghosth Oct 26, 2021
2189159
section name fix for how to reference ASVS
Oct 27, 2021
b935985
Start to do some clarifications in v9
tghosth Oct 28, 2021
ad7d5e0
Additional v9 changes
tghosth Oct 28, 2021
eb05797
Final V9 fixes
tghosth Oct 28, 2021
a2baa95
Update README.md
tghosth Oct 28, 2021
d3ff911
Update document outputs
tghosth Oct 28, 2021
b93ae2f
Update document outputs for 4.0.3
tghosth Oct 28, 2021
1580ee5
Update document outputs for 4.0.3, remove 4.0.3 pdf"
tghosth Oct 28, 2021
98abcd5
Update latest versions on README for v4.0.3
tghosth Oct 28, 2021
2841f0f
Remove space
tghosth Oct 28, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ IMPORTANT NOTES:
- Changes should always be made only in the raw .md files and not in the CSV, JSON, XLSX, PDF, DOCX files, etc.
- Please do not open a pull request without first opening an associated issue.
- Please carry out all discussion in the associated issue only.
- Please refer to the following link for guidance on labeling contributions https://github.com/OWASP/ASVS/blob/master/CONTRIBUTING.md
-->

This Pull Request relates to issue #...
23 changes: 17 additions & 6 deletions 4.0/asvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ class ASVS:
"provides developers with a list of requirements for secure development."

asvs_flat = []
asvs_flat2 = {}
asvs_flat2['requirements'] = []

def __init__(self, language):

Expand Down Expand Up @@ -129,15 +131,16 @@ def __init__(self, language):
if m:

req_flat = {}
req_flat['chapter_id'] = chapter['Shortcode']
req_flat['chapter_name'] = chapter['Name']
req_flat2 = {}
req_flat2['Section'] = req_flat['chapter_id'] = chapter['Shortcode']
req_flat2['Name'] = req_flat['chapter_name'] = chapter['Name']
req_flat['section_id'] = section['Shortcode']
req_flat['section_name'] = section['Name']

req = {}
req_flat['req_id'] = req['Shortcode'] = "V" + m.group(1)
req_flat2['Item'] = req_flat['req_id'] = req['Shortcode'] = "V" + m.group(1)
req['Ordinal'] = int(m.group(1).rsplit('.', 1)[1])
req_flat['req_description'] = req['Description'] = m.group(2)
req_flat2['Description'] = req_flat['req_description'] = req['Description'] = m.group(2)

level1 = {}
level2 = {}
Expand All @@ -148,8 +151,11 @@ def __init__(self, language):
req_flat['level3'] = m.group(5).strip(' ')

level1['Required'] = m.group(3).strip() != ''
req_flat2['L1'] = ('X' if level1['Required'] else '')
level2['Required'] = m.group(4).strip() != ''
req_flat2['L2'] = ('X' if level2['Required'] else '')
level3['Required'] = m.group(5).strip() != ''
req_flat2['L3'] = ('X' if level3['Required'] else '')

level1['Requirement'] = ("Optional" if m.group(3).strip('✓ ') == "o" else m.group(3).strip('✓ '))
level2['Requirement'] = ("Optional" if m.group(4).strip('✓ ') == "o" else m.group(4).strip('✓ '))
Expand All @@ -160,17 +166,22 @@ def __init__(self, language):
req['L3'] = level3

req['CWE'] = [int(i.strip()) for i in filter(None, m.group(6).strip().split(','))]
req_flat['cwe'] = m.group(6).strip()
req_flat2['CWE'] = req_flat['cwe'] = m.group(6).strip()
req['NIST'] = [str(i.strip()) for i in filter(None,m.group(7).strip().split('/'))]
req_flat['nist'] = m.group(7).strip()
req_flat2['NIST'] = req_flat['nist'] = m.group(7).strip()

section['Items'].append(req)
self.asvs_flat.append(req_flat)
self.asvs_flat2['requirements'].append(req_flat2)

def to_json(self):
''' Returns a JSON-formatted string '''
return json.dumps(self.asvs, indent = 2, sort_keys = False).strip()

def to_json_flat(self):
''' Returns a JSON-formatted string which is flattened and simpler '''
return json.dumps(self.asvs_flat2, indent = 2, sort_keys = False).strip()

def to_xmlOLD(self):
''' Returns XML '''
xml = ''
Expand Down
Empty file added 4.0/docs_de/de
Empty file.
Loading