Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating navbar to tailwind and implementing mobile design #1060

Merged
merged 12 commits into from
Feb 16, 2023
Merged

Migrating navbar to tailwind and implementing mobile design #1060

merged 12 commits into from
Feb 16, 2023

Conversation

co-decode
Copy link
Contributor

WIP: Would resolve #992
I am in the process of migrating the navbar styling to tailwind.
At the moment I'm just doing a translation of styles I see in our css files, so it's all a bit messy.

I am also trying to implement the mobile design mentioned in issue #992 for screen widths under 640px.
This is what I have so far:

image

Question: What should clicking the settings button on the left do?
Perhaps slide out a menu like in the design:

image

Other things to mention:

  • I have changed the logo image file to the larger version as the small version was cropped at the top and a little grainy.
  • I have removed the duplicate search bar that was appearing below 953px

@fredfalcon
Copy link
Contributor

Looks good! Slide out or down menu is good. As long as it’s fast / snappy.

@AtmegaBuzz
Copy link
Collaborator

Nice!, Looks awesome

@AtmegaBuzz
Copy link
Collaborator

Hey @co-decode. you can join BLT slack for better communication and further discussions. https://owasp.org/slack/invite

@co-decode
Copy link
Contributor Author

co-decode commented Feb 16, 2023

Thank you, I have accepted your invitation!

  1. I have fixed some responsiveness issues with the avatar dropdown ( on the right when the user is logged in ) and with the search bar overlapping the signup and login buttons at small screen widths.

  2. I have kept the dropdown for the settings icon simple and in line with the style of the avatar dropdown:

image

image

Here's what it looks like above 640px.

image

image

Things to mention:

  • I have added an option to test.py to specify screen width. I was thinking of hiding the username under the avatar at small screen widths, but I'll just leave it for now.
  • There is a manual CSS breakpoint at 420px in navbar.css to hide the search icon, this isn't the cleanest solution but it does make things work for mobile screens down to about 370px.

@co-decode co-decode marked this pull request as ready for review February 16, 2023 02:50
@fredfalcon fredfalcon added this pull request to the merge queue Feb 16, 2023
@fredfalcon
Copy link
Contributor

Thank you! Looks great

Merged via the queue into OWASP-BLT:main with commit 19ffd0f Feb 16, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
* updating main origin

* Revert "updating main origin"

This reverts commit a996038.

Linter updated all py files inadvertently

* wip: migrating navbar to tailwind

* wip: nav layout done, needs functionality

* navbar complete and functional

* satisfy test: keep username under avatar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav bar is not like figma design
3 participants