Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic variables to templates #1076

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

Kej-r03
Copy link
Contributor

@Kej-r03 Kej-r03 commented Feb 20, 2023

Fixes #1073
Added custom template tag 'env' to use the settings.py variables inside templates

fredfalcon
fredfalcon previously approved these changes Feb 20, 2023
Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few tweaks required

website/templates/account/login.html Outdated Show resolved Hide resolved
website/templates/account/signup.html Outdated Show resolved Hide resolved
website/templates/domain.html Outdated Show resolved Hide resolved
website/templates/includes/footer.html Outdated Show resolved Hide resolved
website/templates/includes/footer.html Outdated Show resolved Hide resolved
@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 20, 2023

Hi @fredfalcon, I have addressed all the reviews and changed accordingly

fredfalcon
fredfalcon previously approved these changes Feb 20, 2023
@fredfalcon
Copy link
Contributor

Nice work! Thank you!

@fredfalcon fredfalcon added this pull request to the merge queue Feb 21, 2023
Merged via the queue into OWASP-BLT:main with commit d2261fe Feb 21, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
* Add dynamic variables to templates

* Rectify dynamic variables in template

---------

Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure all templates are using the new dynamic variables
2 participants