Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append multiple screenshot in issue json #1078

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Append multiple screenshot in issue json #1078

merged 4 commits into from
Feb 23, 2023

Conversation

Kej-r03
Copy link
Contributor

@Kej-r03 Kej-r03 commented Feb 22, 2023

Fixes #1075

fredfalcon
fredfalcon suggested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works however I think it will be good to have all screenshots attached. Thanks

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 22, 2023

I have attached a screen recording of the working. You can see that we do not get any console errors. Thanks

simplescreenrecorder-2023-02-22_11.34.52.mp4

fredfalcon
fredfalcon suggested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make it attach all screenshots to GitHub?

fredfalcon
fredfalcon suggested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use the IssueScreenshot.image.url function to get the url - Django has a built in image url function.

website/views.py Outdated Show resolved Hide resolved
@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 23, 2023

Ok, I think the first commit was better itself, so I have reverted back. I have created an issue using the github api post method here. Here too the image is not fully loaded though

fredfalcon
fredfalcon suggested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@fredfalcon fredfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add string to first loop

website/views.py Show resolved Hide resolved
@fredfalcon
Copy link
Contributor

ok, that's weird as it seems it's the same object - looks good though, thank you!

@fredfalcon fredfalcon added this pull request to the merge queue Feb 23, 2023
Merged via the queue into OWASP-BLT:main with commit cecd8eb Feb 23, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
@Kej-r03 @fredfalcon
Append multiple screenshot in issue json (#1078)
1629990 
* Append multiple screenshot in issue json

* Fix multiple screenshot issue

* fix screenshot url

---------

Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredfalcon fredfalcon fredfalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GitHub post code to work with multiple screenshots
2 participants
@Kej-r03 @fredfalcon