Add remaining dynamic variables to templates #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredfalcon
suggested changes
Feb 23, 2023
|
Please take a look at this new commit. Also I would clarify one thing, like in footer.html lines 33, 37, 41, 45, "bugheist" is a part of a url, so its case cannot be altered, that is why I have not touched it. |
|
It looks great thank you so much for those links at the footer we can add new variables, blog_URL etc. |
fredfalcon
suggested changes
Feb 25, 2023
|
@Kej-r03 can you please take a look? |
|
Yes, I will make the changes |
|
@fredfalcon I have made the changes, please take a look |
fredfalcon
approved these changes
Feb 28, 2023
|
@fredfalcon Can I resolve the 2 pending conversations so that it can be merged? |
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Add remaining dynamiv variables to templates * Add dynamic variables * Add BLOG_URL settings variable * Add social media urls as variables * Modify remaining dynamic variable in templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
I guess now no other template html file remains with this issue