Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all issues feature #1089

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Hide all issues feature #1089

merged 1 commit into from
Feb 28, 2023

Conversation

Kej-r03
Copy link
Contributor

@Kej-r03 Kej-r03 commented Feb 25, 2023

Fixes #1032. I have implemented the hide all issues feature (see below user profile pic). When it is checked, nobody except the user, can view his issues anywhere on Bugheist.

photo_2023-02-25_18-06-45

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 28, 2023

@fredfalcon please review the feature, so I can extend this to hiding individual issues and complete domain issues as well

@fredfalcon
Copy link
Contributor

It looks good so far. I’d like the ability to hide all of a users issues from their profile with a checkbox to [ ] hide all issues I’ve submitted. We can do the hide all issues from a domain in another issue.

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 28, 2023

Can you please confirm if there are any pending changes or this PR is good to merge

@fredfalcon fredfalcon added this pull request to the merge queue Feb 28, 2023
@fredfalcon
Copy link
Contributor

Looks good! What happens if someone lands on a hidden issue page? Can we return a 404?

Merged via the queue into OWASP-BLT:main with commit 8f8108c Feb 28, 2023
@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 28, 2023

Looks good! What happens if someone lands on a hidden issue page? Can we return a 404?

No I had not taken that into consideration. Will work on that

@fredfalcon
Copy link
Contributor

Instead of a 404, let’s have a page with only the words “this issue has been hidden by the user that reported it.” And then a button “request access”

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 28, 2023

I understood what the page should look like. But I am not sure how will the request feature be implemented. Can you give some pointers on that

@fredfalcon
Copy link
Contributor

It will send an email to the bug reporter “user has requested access to bug” and the user will need to be logged in or signup after clicking.

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 28, 2023

I think you can create it as a separate issue, I will try to work it out in a couple of days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow user's posted issues to be hidden
2 participants