-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding translate button #1376
Adding translate button #1376
Conversation
Thanks for the PR @daemon-reconfig, can you also add a screenshot in the PR |
Awesome looks good, just need little margin left of 2 - 3 px can you add that |
sure |
LGTM @DonnieBLT |
Can you please make it look like a button and not an input field? Also can you remove the powered by google logo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment
These changes cannot be made although i can try making it look like a button but the "Powered by google" text cannot be removed as it is the USP of google. |
I did try making it like a button but it did not work as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make it look like the last example here and please show a screenshot https://www.w3schools.com/howto/howto_google_translate.asp
Did you commit the change? |
Yes that looks good |
I waited for your approval let me do so now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
solves #680