Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translate button #1376

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

daemon-reconfig
Copy link
Contributor

@daemon-reconfig daemon-reconfig commented Aug 23, 2023

solves #680

@AtmegaBuzz
Copy link
Collaborator

Thanks for the PR @daemon-reconfig, can you also add a screenshot in the PR

@daemon-reconfig
Copy link
Contributor Author

daemon-reconfig commented Aug 23, 2023

Screenshot 2023-08-23 at 6 43 57 PM @AtmegaBuzz

@AtmegaBuzz
Copy link
Collaborator

Awesome looks good, just need little margin left of 2 - 3 px can you add that

@daemon-reconfig
Copy link
Contributor Author

sure

@daemon-reconfig
Copy link
Contributor Author

I have added margin to left side
Screenshot 2023-08-24 at 12 14 33 AM

How it works
by simply choosing the language the user can change the language.
Screenshot 2023-08-24 at 12 16 08 AM

@AtmegaBuzz
Copy link
Collaborator

LGTM @DonnieBLT

@DonnieBLT
Copy link
Collaborator

Can you please make it look like a button and not an input field? Also can you remove the powered by google logo?

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment

@daemon-reconfig
Copy link
Contributor Author

These changes cannot be made although i can try making it look like a button but the "Powered by google" text cannot be removed as it is the USP of google.
Although i doubt i can make it in a button as it is a script provided by google.
if there are any alternatives that do fit your requirements, please do let me know

@daemon-reconfig
Copy link
Contributor Author

I did try making it like a button but it did not work as intended.

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it look like the last example here and please show a screenshot https://www.w3schools.com/howto/howto_google_translate.asp

@daemon-reconfig
Copy link
Contributor Author

daemon-reconfig commented Aug 24, 2023

Screenshot 2023-08-24 at 10 07 02 PM does this work? I will add 2-3px of margin to the bottom

@daemon-reconfig
Copy link
Contributor Author

Screenshot 2023-08-24 at 10 11 22 PM

There

@DonnieBLT
Copy link
Collaborator

Did you commit the change?

@DonnieBLT
Copy link
Collaborator

Yes that looks good

@daemon-reconfig
Copy link
Contributor Author

I waited for your approval let me do so now

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daemon-reconfig
Copy link
Contributor Author

now I will work on more good first issues hehe. by the way can I improve the UI here?
Screenshot 2023-08-24 at 10 35 19 PM

@DonnieBLT DonnieBLT merged commit da9faa8 into OWASP-BLT:main Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants