Fixed Issue #121 #179
Merged
Fixed Issue #121 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @farziengineer -- I'm not sure if you got the issue #121. It says that, user can access the service entirely except they'll be shown a banner somewhere on top to confirm his email address. |
|
@souravbadami Hey Sourav, the issue heading says that "Without confirming the email address. user is able to login into the website", which should not happen. And yes even now they are being shown a banner to confirm their email address.More precisely it explicitly mentions that the user cannot access the service until he has verified his email. I hope this is clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the user cannot login without email confirmation.