Design improvements in pages #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajodiaraghav
changed the title
jajodiaraghav
changed the title
|
@souravbadami Please review this PR. |
souravbadami
suggested changes
Jun 11, 2017
website/templates/email.html
Outdated
| <div class="col-lg-12"> | ||
| <p>{{emails}}</p> | ||
| </div> | ||
| </div> | ||
| {% endblock %} |
There was a problem hiding this comment.
Add a line ending here.
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Add a line ending here.
| #login p { | ||
| font-size: 13px; | ||
| padding-top: 20px; | ||
| } |
There was a problem hiding this comment.
Add a line ending here.
website/static/css/main.css
Outdated
| background: #eee; | ||
| border-radius: 50%; | ||
| font-size: 30px; | ||
| box-shadow: 0 1px 1px #dd4252; | ||
| } | ||
|
|
||
|
|
||
| .no-shadow{ | ||
| box-shadow: 0 0 0 #000; |
There was a problem hiding this comment.
Replace tab with 4 spaces.
website/static/css/main.css
Outdated
| @@ -1,30 +1,68 @@ | |||
| .fa{ | |||
| color: #555; | |||
There was a problem hiding this comment.
Replace tab with 4 spaces. Also, look for indentation with 4 spaces in this entire file. I can see several places that has to be fixed.
Remove inline css Remove useless JS snippets Improve design Refactor code for better readabilty Fix indentation Add a line at the end
|
@souravbadami Updated the commit |
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
Remove inline css Remove useless JS snippets Improve design Refactor code for better readabilty Fix indentation Add a line at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit handles the following: