Removed inline CSS #348
Merged
Removed inline CSS #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you sure there aren't anymore inline css present? |
|
Ok, I will check again in using Find. |
|
Hey @jajodiaraghav should I also work on inline style tags which have dynamic values. |
|
@goyal-sidd No. You do not have to remove them. Leave them as is |
|
I have removed most of style tags, the ones remaining are that are with dynamic entries or are single. |
|
This looks much better. Thanks @goyal-sidd |
fredfalcon
approved these changes
Jul 11, 2017
sid22
added a commit
to sid22/BLT
that referenced
this pull request
Sep 5, 2017
* Removed inline CSS * Removed style from subscriptions' * Removed style from profile
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Removed inline CSS * Removed style from subscriptions' * Removed style from profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed inline CSS from all the template html files. The some places left are dynamic.
If I have missed anything kindly tell me.
Solves #236