Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Django to 1.10 #361

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Upgrade Django to 1.10 #361

merged 1 commit into from
Jul 13, 2017

Conversation

jajodiaraghav
Copy link
Contributor

No description provided.

@jajodiaraghav jajodiaraghav merged commit 0a43a27 into OWASP-BLT:master Jul 13, 2017
@fredfalcon
Copy link
Contributor

Can you please fix it so the tests work?

@jajodiaraghav
Copy link
Contributor Author

As explained on slack, actstream is not compatible with either Django 1.10 or 1.11. Hence the error:

File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/actstream/urls.py", line 5, in <module>
from django.conf.urls.defaults import url, patterns
ImportError: No module named defaults

We can easily fix the error by editing /home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/actstream/urls.py and changing
this-> from django.conf.urls.defaults import url, patterns
to-> from django.conf.urls import *

I am not sure how to do this in travis. @souravbadami Can you help?

@jajodiaraghav jajodiaraghav deleted the patch_1 branch July 13, 2017 14:23
@souravbadami
Copy link
Collaborator

@jajodiaraghav -- I think, it is not possible to do that within Travis or any other CI tool. Also, it is not a good practice too. Maybe, if it would have been possible to do that -- it'd be a bit overhead. Because, for each commit -- Travis builds the entire system for tests and installs the packages. So, changing that every time won't be easy (mind the easy keyword, because it can be easily done using a small script but not advisable).

souravbadami added a commit to souravbadami/BLT that referenced this pull request Jul 13, 2017
fredfalcon pushed a commit that referenced this pull request Jul 14, 2017
* Reformatted code structure to follow pep8. #364

* Reverting back #361.
sid22 pushed a commit to sid22/BLT that referenced this pull request Sep 5, 2017
sid22 pushed a commit to sid22/BLT that referenced this pull request Sep 5, 2017
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
* Reformatted code structure to follow pep8. #364

* Reverting back #361.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants