Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-for-duplicates feature added #392

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Check-for-duplicates feature added #392

merged 1 commit into from
Jul 20, 2017

Conversation

jajodiaraghav
Copy link
Contributor

No description provided.

@jajodiaraghav
Copy link
Contributor Author

jajodiaraghav commented Jul 20, 2017

@goyal-sidd Please have a look at the code here. I have closed your PR as it had several bugs and issues. Also the url error that I asked you to fixed wasn't fixed. Please read this code to learn the right fix.
BTW, you are authored in this commit, don't worry.

This isn't completely fixed yet. There is more error in the domain_check views file:
screenshot from 2017-07-20 11-11-50

Copy link
Contributor

@sid22 sid22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new styling looks good.

@jajodiaraghav jajodiaraghav merged commit 32093dd into OWASP-BLT:master Jul 20, 2017
@jajodiaraghav jajodiaraghav deleted the goyal-sidd-domain_p branch July 20, 2017 09:49
sid22 pushed a commit to sid22/BLT that referenced this pull request Sep 5, 2017
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants