Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put footer to bottom #395

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Put footer to bottom #395

merged 1 commit into from
Jul 20, 2017

Conversation

jajodiaraghav
Copy link
Contributor

Fixes #391

@sid22
Copy link
Contributor

sid22 commented Jul 20, 2017

Does it work for mobile view (height) etc. I was also working on it but was stuck for the mobile view only.

@jajodiaraghav
Copy link
Contributor Author

Yes it works for all views equally well

sid22
sid22 approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@sid22 sid22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sid22 sid22 merged commit ab5d02d into OWASP-BLT:master Jul 20, 2017
@jajodiaraghav jajodiaraghav deleted the patch_2 branch July 20, 2017 16:21
@jajodiaraghav jajodiaraghav mentioned this pull request Jul 21, 2017
Closed
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
@sid22
Merge pull request #395 from jajodiaraghav/patch_2
4a8176e 
Put footer to bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid22 sid22 sid22 approved these changes

@fredfalcon fredfalcon Awaiting requested review from fredfalcon

@mohitanand001 mohitanand001 Awaiting requested review from mohitanand001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Week 31 - Mid Term Evaluations Due
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jajodiaraghav @sid22