Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doughnut chart in stats #468

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Add doughnut chart in stats #468

merged 1 commit into from
Aug 11, 2017

Conversation

jajodiaraghav
Copy link
Contributor

No description provided.

sid22
sid22 reviewed Aug 10, 2017
View reviewed changes
website/templates/stats.html Outdated
<canvas id="issueChart"></canvas>
</div>
</div>
<br/>
Copy link
Contributor

@sid22 sid22 Aug 10, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a typo here, it's <br/> instead of <br>

sid22
sid22 suggested changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@sid22 sid22 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also sir, even after I corrected the <br> tag locally, the graph was still touching the footer. Maybe if a margin-bottom is added to this div or more than one <br> tag.

The chart looks awesome either way though!

@jajodiaraghav
Copy link
Contributor Author

jajodiaraghav commented Aug 11, 2017 •
edited

The issue is fixed! Replaced <br> with margin bottom :)

@sid22 sid22 merged commit fe8f61e into OWASP-BLT:master Aug 11, 2017
@jajodiaraghav jajodiaraghav deleted the patch_1 branch August 24, 2017 05:34
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
@sid22
Merge pull request #468 from jajodiaraghav/patch_1
ec5fb02 
Add doughnut chart in stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid22 sid22 sid22 approved these changes

@fredfalcon fredfalcon Awaiting requested review from fredfalcon

@mohitanand001 mohitanand001 Awaiting requested review from mohitanand001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jajodiaraghav @sid22