Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all swift code to Swift 5 #961

Closed
commjoen opened this issue Aug 6, 2018 · 15 comments · Fixed by #1856
Closed

Upgrade all swift code to Swift 5 #961

commjoen opened this issue Aug 6, 2018 · 15 comments · Fixed by #1856
Assignees
Projects

Comments

@commjoen
Copy link
Collaborator

commjoen commented Aug 6, 2018

We need to update all swift code to Swift 4.1, so that it is consistent and understandable for people who just switched to Swift development.

@commjoen commjoen added this to To do in OWASP MSTG via automation Aug 6, 2018
@commjoen commjoen assigned commjoen and unassigned commjoen Aug 6, 2018
@commjoen
Copy link
Collaborator Author

commjoen commented Aug 6, 2018

@funky-monkey will help in here. Welcome to the team!

@funky-monkey
Copy link

Thanks! I'll have a look and see if i am able to help out

@sushi2k
Copy link
Collaborator

sushi2k commented Aug 6, 2018

Hey @funky-monkey. You just got an invite from Github. Please accept then I assign this ticket for you. Thanks for the support!

@funky-monkey
Copy link

Thanks @sushi2k I've accepted 👍

@sushi2k
Copy link
Collaborator

sushi2k commented Aug 8, 2018

It's all yours :-) Thanks for your help!

@commjoen commjoen added this to the 1.2: Android and iOS updates milestone Aug 10, 2018
@commjoen commjoen moved this from To do to In progress in OWASP MSTG Aug 10, 2018
@sushi2k sushi2k changed the title Upgrade all swift code to Swift 4.1 Upgrade all swift code to Swift 4.2 Jan 15, 2019
@sushi2k
Copy link
Collaborator

sushi2k commented Jan 15, 2019

Hi @funky-monkey. Any update for this ticket? Are you still interested in adding Swift source code? It should also be now Swift 4.2 instead of 4.1

@funky-monkey
Copy link

funky-monkey commented Jan 15, 2019 via email

@funky-monkey
Copy link

Hi @sushi2k, @commjoen,

A lot has changed in my personal life and I need to focus on other things. I'm a little sad I can't pick this up. I hope you can find someone else to make this shine.

Cheers,
Sidney

@commjoen
Copy link
Collaborator Author

No worries! We will look for a new volunteer :)

@commjoen commjoen moved this from In progress to To do in OWASP MSTG Mar 20, 2019
@commjoen commjoen changed the title Upgrade all swift code to Swift 4.2 Upgrade all swift code to Swift 5 May 17, 2019
@commjoen
Copy link
Collaborator Author

So with swift 5 we have to update it again ;-)

@commjoen
Copy link
Collaborator Author

Still looking for a volunteer!

@commjoen
Copy link
Collaborator Author

Assigned for @cak. Welcome aboard!

@cak cak mentioned this issue Aug 27, 2019
6 tasks
@commjoen commjoen moved this from To do to In progress in OWASP MSTG Aug 30, 2019
@cak cak mentioned this issue Oct 1, 2019
6 tasks
@cpholguera
Copy link
Collaborator

Hi @cak , could you start working on this one as well? Please let us know, thanks!

@cak
Copy link
Collaborator

cak commented Dec 15, 2019

Hey @cpholguera, yes, I will make another pass. I need to add references to Combine (and SwiftUI) where relevant as well.

@cpholguera
Copy link
Collaborator

Awesome. Thanks a lot for the quick response!

@cpholguera cpholguera added the iOS label Aug 26, 2020
@cpholguera cpholguera added the org label Aug 26, 2020
OWASP MSTG automation moved this from In progress to Done Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OWASP MSTG
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants