Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub issues in leanpub #1216

Closed
commjoen opened this issue May 21, 2019 · 2 comments
Closed

epub issues in leanpub #1216

commjoen opened this issue May 21, 2019 · 2 comments
Assignees
Projects

Comments

@commjoen
Copy link
Collaborator

commjoen commented May 21, 2019

AFter the book fixes, we end up with the following issues from leanpub on our epub format:


We found the following errors:      
We found the following problems with your epub file:
- Error while parsing file 'value of attribute "id" is invalid; must be an XML name without colons'.  
- Error while parsing file 'element "img" missing required attribute "alt"'.  
- Error while parsing file 'element "pin_" not allowed anywhere; expected the element end-tag, text or element "a", "abbr", "acronym", "applet", "b", "bdo", "big", "br", "cite", "code", "del", "dfn", "em", "i", "iframe", "img", "ins", "kbd", "map", "noscript", "ns:svg", "object", "q", "samp", "script", "small", "span", "strong", "sub", "sup", "tt" or "var" (with xmlns:ns="http://www.w3.org/2000/svg")'.  
- Error while parsing file 'element "application.app" not allowed anywhere; expected the element end-tag, text or element "a", "abbr", "acronym", "applet", "b", "bdo", "big", "br", "cite", "code", "del", "dfn", "em", "i", "iframe", "img", "ins", "kbd", "map", "noscript", "ns:svg", "object", "q", "samp", "script", "small", "span", "strong", "sub", "sup", "tt" or "var" (with xmlns:ns="http://www.w3.org/2000/svg")'. 
@commjoen commjoen added this to To do in OWASP MSTG via automation May 21, 2019
@commjoen commjoen added this to the 1.2: Android and iOS updates milestone May 21, 2019
@commjoen
Copy link
Collaborator Author

Basically it means we have to use real markdown URL markup , alt in img tags and then see if it works again.

@TheDauntless
Copy link
Collaborator

TheDauntless commented May 22, 2019

You can test with this library: https://github.com/w3c/epubcheck/releases

java -jar epubcheck.jar ../owasp-mstg/Generated/MSTG-EN.epub

I fixed a few, but I have no idea why the following is still not working correctly:

ERROR(RSC-005): /Users/jbeckers/Documents/Projects/owasp_push/owasp-mstg/Generated/MSTG-EN.epub/0x05g-Testing-Network-Communication.html(145,122): Error while parsing file: element "pin_" not allowed anywhere; expected the element end-tag, text or element "a", "abbr", "acronym", "applet", "b", "bdo", "big", "br", "cite", "code", "del", "dfn", "em", "i", "iframe", "img", "ins", "kbd", "map", "noscript", "ns:svg", "object", "q", "samp", "script", "small", "span", "strong", "sub", "sup", "tt" or "var" (with xmlns:ns="http://www.w3.org/2000/svg")
ERROR(RSC-005): /Users/jbeckers/Documents/Projects/owasp_push/owasp-mstg/Generated/MSTG-EN.epub/0x06b-Basic-Security-Testing.html(184,64): Error while parsing file: element "img" missing required attribute "alt"
ERROR(RSC-005): /Users/jbeckers/Documents/Projects/owasp_push/owasp-mstg/Generated/MSTG-EN.epub/0x06b-Basic-Security-Testing.html(185,44): Error while parsing file: element "img" missing required attribute "alt"

They should be easy fixes, but my computer isn't cooperating today :).

Can someone take a look (git checkout FixEPUB)? It's basically 3 lines that need to be edited...

commjoen added a commit that referenced this issue May 22, 2019
OWASP MSTG automation moved this from To do to Done May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
OWASP MSTG
  
Done
Development

No branches or pull requests

4 participants