Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy and account validation occurs after the keys lookup stage #1452

Open
carlfischerjba opened this issue Apr 17, 2023 · 0 comments
Open
Assignees

Comments

@carlfischerjba
Copy link
Contributor

Issue Description

Validation of the policies and accounts (oasislmf.preparation.il_inputs.get_il_input_items) occurs after the keys lookup stage (oasislmf.lookup.factory.generate_key_files). This can cause much time to be wasted if the user only finds out about portfolio problems after several hours.

Steps to Reproduce (Bugs only)

Version / Environment information

  • NRMC - 23.03 (OasisPlatform 1.23.14-lts)
  • OasisLMF in worker: 1.26.4

Example data / logs

Stating oasislmf command - GenerateOasisFiles
RUNNING: oasislmf.manager.interface

Processing arguments - Creating Oasis Files

Generating Oasis files (GUL=True, IL=True, RIL=True)
RUNNING: oasislmf.lookup.factory.generate_key_files
COMPLETED: oasislmf.lookup.factory.generate_key_files in 23087.81s

Keys successful: /tmp/tmpeb7cgowf/keys.csv generated with 405076 items
Keys errors: /tmp/tmpeb7cgowf/keys-errors.csv generated with 831230 items
RUNNING: oasislmf.preparation.gul_inputs.get_gul_input_items
COMPLETED: oasislmf.preparation.gul_inputs.get_gul_input_items in 3.28s
RUNNING: oasislmf.preparation.summaries.write_exposure_summary
RUNNING: oasislmf.preparation.summaries.write_gul_errors_map
COMPLETED: oasislmf.preparation.summaries.write_gul_errors_map in 3.62s
RUNNING: oasislmf.preparation.summaries.get_exposure_summary
RUNNING: oasislmf.preparation.summaries.get_exposure_totals
COMPLETED: oasislmf.preparation.summaries.get_exposure_totals in 2.53s
COMPLETED: oasislmf.preparation.summaries.get_exposure_summary in 24.89s
COMPLETED: oasislmf.preparation.summaries.write_exposure_summary in 29.1s
RUNNING: oasislmf.preparation.summaries.write_summary_levels
COMPLETED: oasislmf.preparation.summaries.write_summary_levels in 0.24s
RUNNING: oasislmf.preparation.gul_inputs.write_gul_input_files
RUNNING: oasislmf.preparation.gul_inputs.write_complex_items_file
COMPLETED: oasislmf.preparation.gul_inputs.write_complex_items_file in 1.05s
RUNNING: oasislmf.preparation.gul_inputs.write_items_file
COMPLETED: oasislmf.preparation.gul_inputs.write_items_file in 0.97s
RUNNING: oasislmf.preparation.gul_inputs.write_coverages_file
COMPLETED: oasislmf.preparation.gul_inputs.write_coverages_file in 0.65s
COMPLETED: oasislmf.preparation.gul_inputs.write_gul_input_files in 2.8s
RUNNING: oasislmf.preparation.summaries.get_summary_mapping
COMPLETED: oasislmf.preparation.summaries.get_summary_mapping in 0.05s
RUNNING: oasislmf.preparation.summaries.write_mapping_file
COMPLETED: oasislmf.preparation.summaries.write_mapping_file in 2.0s
RUNNING: oasislmf.preparation.il_inputs.get_il_input_items
locations have policies, accounts combination not present in the account file 
locnumber portnumber accnumber condtag
   1234              2      9258    2640
   1235              2      9258    2640
   1236              2      9258    2640
   ...                    ...     ...         ...
@benhayes21 benhayes21 transferred this issue from OasisLMF/OasisPlatform Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants