Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ri_scope filter #1505

Merged
merged 6 commits into from
May 30, 2024
Merged

support ri_scope filter #1505

merged 6 commits into from
May 30, 2024

Conversation

sstruzik
Copy link
Contributor

Support ri_scope file filter

  • Support all the filter in ri_scope ('CedantName', 'ProducerName', 'LOB', 'CountryCode', 'ReinsTag')
  • revamp ri file generation step for speed and simplicity

@sstruzik sstruzik added the feature A main feature, captured on the backlog label May 16, 2024
@sstruzik sstruzik self-assigned this May 16, 2024
@sstruzik sstruzik linked an issue May 16, 2024 that may be closed by this pull request
Copy link
Contributor

@johcarter johcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superbe!
see reinsurance3 tests

@benhayes21 benhayes21 requested review from hchagani-oasislmf and removed request for benhayes21 May 23, 2024 10:07
Copy link
Contributor

@hchagani-oasislmf hchagani-oasislmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sambles sambles merged commit 083911a into main May 30, 2024
24 checks passed
@sambles sambles deleted the feature/ri_filter branch May 30, 2024 05:51
sambles pushed a commit that referenced this pull request May 30, 2024
* support ri_scope filter

* added ri scope test folder

* pep8

* added more ri scope filter tests with expected folder and updated doc

* remove obsolete ri unit tests

* fixup

---------

Co-authored-by: Joh Carter <johanna.carter@oasislmf.org>
@sambles sambles mentioned this pull request May 30, 2024
4 tasks
@awsbuild awsbuild added this to the 2.3.5 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A main feature, captured on the backlog LTS - 2.3
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RI Scope file filters
5 participants