removed Start(string profile, string environment)

Accenture · Apr 22, 2018 · 16d64d7 · 16d64d7
1 parent 71c745c
commit 16d64d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 35 deletions.
diff --git a/.gitignore b/.gitignore
@@ -16,3 +16,4 @@ LastBuild.log
 /myresults.xml
 /opencoverCoverage.xml
 /.nuget/NuGet.exe
+/.vs/TestFramework/v15/Server/sqlite3
diff --git a/Objectivity.Test.Automation.Common/DriverContext.cs b/Objectivity.Test.Automation.Common/DriverContext.cs
@@ -549,39 +549,6 @@ public void Start()
             }
         }
 
-        /// <summary>
-        /// Starts the specified Driver.
-        /// </summary>
-        /// <param name="profile">CrossBrowser profile.</param>
-        /// <param name="environment">CrossBrowser environment.</param>
-        /// <exception cref="NotSupportedException">When driver not supported</exception>
-        [SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope", Justification = "Driver disposed later in stop method")]
-        public void Start(string profile, string environment)
-        {
-            this.CrossBrowserProfile = profile;
-            this.CrossBrowserEnvironment = environment;
-
-            switch (BaseConfiguration.TestBrowser)
-            {
-                case BrowserType.RemoteWebDriver:
-                case BrowserType.CloudProvider:
-                    this.driver = new RemoteWebDriver(BaseConfiguration.RemoteWebDriverHub, this.SetCapabilities());
-                    break;
-                default:
-                    throw new NotSupportedException(
-                        string.Format(CultureInfo.CurrentCulture, "Driver {0} is not supported", BaseConfiguration.TestBrowser));
-            }
-
-            this.driver.Manage().Timeouts().PageLoad = TimeSpan.FromSeconds(BaseConfiguration.LongTimeout);
-            this.driver.Manage().Timeouts().AsynchronousJavaScript = TimeSpan.FromSeconds(BaseConfiguration.ShortTimeout);
-            this.driver.Manage().Timeouts().ImplicitWait = TimeSpan.FromMilliseconds(BaseConfiguration.ImplicitlyWaitMilliseconds);
-
-            if (BaseConfiguration.EnableEventFiringWebDriver)
-            {
-                this.driver = new MyEventFiringWebDriver(this.driver);
-            }
-        }
-
         /// <summary>
         /// Maximizes the current window if it is not already maximized.
         /// </summary>
@@ -786,7 +753,7 @@ private DesiredCapabilities SetCapabilities()
                 for (var i = 0; i < driverCapabilitiesConf.Count; i++)
                 {
                     string value = driverCapabilitiesConf.GetValues(i)[0];
-                    Logger.Trace(CultureInfo.CurrentCulture, "Adding driver capability {0}", driverCapabilitiesConf.GetKey(i));
+                    Logger.Debug(CultureInfo.CurrentCulture, "Adding driver capability {0}", driverCapabilitiesConf.GetKey(i));
                     capabilities.SetCapability(driverCapabilitiesConf.GetKey(i), value);
                 }
             }
@@ -808,22 +775,26 @@ private DesiredCapabilities SetCapabilities()
         /// <returns>Instance with set CloudProvider driver capabilities.</returns>
         private DesiredCapabilities CloudProviderCapabilities(DesiredCapabilities capabilities)
         {
+            Logger.Debug(CultureInfo.CurrentCulture, "Cross Browser Profile '{0}'", this.CrossBrowserProfile.ToString());
             if (!string.IsNullOrEmpty(this.CrossBrowserProfile))
             {
                 NameValueCollection caps = ConfigurationManager.GetSection("capabilities/" + this.CrossBrowserProfile) as NameValueCollection;
 
                 foreach (string key in caps.AllKeys)
                 {
+                    Logger.Debug(CultureInfo.CurrentCulture, "Adding driver capability {0} from {1}", key, this.CrossBrowserProfile);
                     capabilities.SetCapability(key, caps[key]);
                 }
             }
 
+            Logger.Debug(CultureInfo.CurrentCulture, "Cross Browser Environment '{0}'", this.CrossBrowserEnvironment.ToString());
             if (!string.IsNullOrEmpty(this.CrossBrowserEnvironment))
                 {
                 NameValueCollection settings = ConfigurationManager.GetSection("environments/" + this.CrossBrowserEnvironment) as NameValueCollection;
                 foreach (string key in settings.AllKeys)
                     {
-                        if (key == "browser")
+                    Logger.Debug(CultureInfo.CurrentCulture, "Adding driver capability {0} from {1}", key, this.CrossBrowserEnvironment);
+                    if (key == "browser")
                         {
                             capabilities.SetCapability(CapabilityType.BrowserName, settings[key]);
                         }