Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic chainID in EIP712 sigs #1201

Closed
corverroos opened this issue Sep 29, 2022 · 1 comment
Closed

Support dynamic chainID in EIP712 sigs #1201

corverroos opened this issue Sep 29, 2022 · 1 comment
Assignees
@xenowits

Comments

@corverroos
Copy link
Contributor

Problem to be solved

We currently hardcode chainID=1 when calculating EIP712 structured data.

Proposed solution

Add support for dynamic chainID based on forkversion.

Out of Scope

Change EIP712 structure.
@corverroos corverroos mentioned this issue Sep 29, 2022
Merged
@xenowits
Copy link
Contributor

xenowits commented Oct 4, 2022

Completed as part of #1169

@xenowits xenowits closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corverroos @xenowits