Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DutyRandao in sigagg #219

Closed
corverroos opened this issue Mar 15, 2022 · 0 comments · Fixed by #288
Closed

Support DutyRandao in sigagg #219

corverroos opened this issue Mar 15, 2022 · 0 comments · Fixed by #288
Assignees
@dB2510
Labels
enhancement New feature or request
Milestone
Charon V0

Comments

@corverroos
Copy link
Contributor

Problem to solve

We are adding support for DutyRandao, but the sigagg component doesn't support it yet.

Proposed solution

  • See Support DutyRandao in validatorapi #218 for decoding core.ParSignedData into eth2p0.BLSSignature
  • Define (De|En)codeRandaoAggSignedData, using eth2p0.BLSSignature as the type.
  • Support DutyRandao in getAggSignedData and getSignedRoot
@corverroos corverroos added the enhancement New feature or request label Mar 15, 2022
@corverroos corverroos added this to the Charon V0 milestone Mar 15, 2022
@corverroos corverroos mentioned this issue Mar 15, 2022
Closed
@dB2510 dB2510 self-assigned this Mar 25, 2022
This was referenced Mar 25, 2022
Merged
Merged
@dB2510 dB2510 linked a pull request Mar 25, 2022 that will close this issue
core/sigagg: add dutyrandao to sigagg #288
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
enhancement New feature or request
Projects
None yet
Milestone
Charon V0
Development

Successfully merging a pull request may close this issue.

core/sigagg: add dutyrandao to sigagg ObolNetwork/charon
2 participants
@corverroos @dB2510