Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commands tests #101

Open
Seb-stian opened this issue May 7, 2021 · 4 comments
Open

Fix commands tests #101

Seb-stian opened this issue May 7, 2021 · 4 comments
Assignees
@Naamloos
Labels
bug Something isn't working commands Relates to Obsidian.Commands priority: medium Moderately important

Comments

@Seb-stian
Copy link
Member

Commands.TestCommandExec() fails with an exception:

❌ Obsidian.Commands.Framework.Exceptions.InvalidCommandOverloadException : No such overload for command pong

It seems that command groups are not registered properly.
@Seb-stian Seb-stian added bug Something isn't working commands Relates to Obsidian.Commands labels May 7, 2021
@JeremyEspresso
Copy link
Contributor

Could I be assigned to this issue?

@JeremyEspresso
Copy link
Contributor

After having looked at the issue, it seems that the test in question doesn't have the functionality built in yet that it's testing.

See: https://github.com/ObsidianMC/Obsidian/blob/ca9c85c77f6336f7d36386aaedd2b0b578d5fb91/Obsidian.Tests/Commands.cs#L25

CC @Naamloos

@JeremyEspresso JeremyEspresso removed their assignment May 13, 2021
@Naamloos
Copy link
Member

The test hasn't been updated when I updated the command framework.. I think

@Naamloos
Copy link
Member

ohh seems like the functionality is indeed not yet there.

I'll keep this one open for when I refactor the command framework some more.

@Seb-stian Seb-stian changed the title Fix commands Fix commands tests Jun 16, 2021
@Naamloos Naamloos added the priority: medium Moderately important label Jan 9, 2022
@Naamloos Naamloos mentioned this issue Jan 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Naamloos Naamloos

Labels
bug Something isn't working commands Relates to Obsidian.Commands priority: medium Moderately important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Naamloos @Seb-stian @JeremyEspresso