Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration through ENV variables #407

Closed
Naamloos opened this issue Nov 23, 2023 · 5 comments · Fixed by #437
Closed

Allow configuration through ENV variables #407

Naamloos opened this issue Nov 23, 2023 · 5 comments · Fixed by #437
Labels
docker Relates to docker support enhancement New feature or request priority: low Nice to have server Relates to the server implementation

Comments

@Naamloos
Copy link
Member

This would make it easier to configure Obsidian when hosting it through docker, since no files will have to be modified manually.
@Naamloos Naamloos added enhancement New feature or request server Relates to the server implementation priority: low Nice to have docker Relates to docker support labels Nov 23, 2023
@Tides
Copy link
Member

Tides commented Nov 24, 2023

To add to this, We should make use of IConfigurationManager stuff and move away from how we currently do configuration ^ ^

@Craftplacer
Copy link
Collaborator

What configuration is planned? Ports only? Or all settings?

@Craftplacer Craftplacer reopened this Nov 25, 2023
@Craftplacer
Copy link
Collaborator

(oops, thanks shithub)

@Naamloos
Copy link
Member Author

if doable: all

@Naamloos
Copy link
Member Author

To add to this, We should make use of IConfigurationManager stuff and move away from how we currently do configuration ^ ^

Probably a good idea, IConfigurationManager can fetch config values from multiple sources, be it env variables, a config file, etc etc

@Tides Tides mentioned this issue May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker Relates to docker support enhancement New feature or request priority: low Nice to have server Relates to the server implementation
Projects
Obsidian Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better Configuration ObsidianMC/Obsidian
3 participants
@Naamloos @Tides @Craftplacer