Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translations): Add pt-BR localization strings #39

Merged
merged 3 commits into from Feb 16, 2022

Conversation

DanielSouzaBertoldi
Copy link
Contributor

@DanielSouzaBertoldi DanielSouzaBertoldi commented Feb 14, 2022

This PR translates both Localizable.strings and Main.strings to Brazilian Portuguese.

Evidences:

image

Note: Unfortunately the description for both URL and HTML decoder/encoder ended up a little bigger than the card. Is there something I can do about it?

Kapture 2022-02-14 at 07 31 52

This is my first time ever contributing to a project written in Swift, so if anything's wrong please tell me :)

@DanielSouzaBertoldi DanielSouzaBertoldi marked this pull request as ready for review February 14, 2022 10:24
@DanielSouzaBertoldi DanielSouzaBertoldi changed the title Add pt-BR localization strings feat(translations): Add pt-BR localization strings Feb 14, 2022
Copy link

@mattvasc mattvasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a Brazilian dude, and I did like the translations.

@JhonataCampos
Copy link

Pretty solid translations. Keep up the good work!! Recommended.

@tlacerdat
Copy link

Nice job, as a Brazilian, I can say that the translation was incredible.

@carlagaama
Copy link

Great job on this translation! So detailed that people won't have to use Google translate anymore.

@lubuzzo
Copy link

lubuzzo commented Feb 14, 2022

LGTM.

I recently started using DevToysMac instead of a couple of different websites, specific for each task - this translation can help even more my life, and other portuguese programmers.

@ObuchiYuki
Copy link
Collaborator

@DanielSouzaBertoldi @mattvasc @JhonataCampos @carlagaama @lubuzzo
Thank you for your PR and translation checks! The translation work is very helpful, and I'm glad DevToys for Mac is helping you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants