Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research Borg Hand Analyser Sync deletes all stored points. #212

Open
4 of 5 tasks
Hawk-v3 opened this issue Feb 4, 2021 · 3 comments
Open
4 of 5 tasks

Research Borg Hand Analyser Sync deletes all stored points. #212

Hawk-v3 opened this issue Feb 4, 2021 · 3 comments
Labels
Bug Something isn't working as intended. 👥 Impact: I-5 Minimal (How many users is it expected to affect?) 0 - 1 ⚠️ Severity: S-2 Major Issue that will cause issues to gameplay, and will hinder the player.

Comments

@Hawk-v3
Copy link
Contributor

Hawk-v3 commented Feb 4, 2021

Description of issue

See title.

Difference between expected and actual behavior

Expected:
Find 10K worth of research points with a friendly Maintcrawler.
Synch points to server.
See: "You connect to the research server, push your data upstream to it, then pull the resulting merged data from the master branch."
Goto R&D Console.
See 10K points.

Actual:
Find 10K worth of research points with a friendly Maintcrawler.
Synch points to server.
See: "You connect to the research server, push your data upstream to it, then pull the resulting merged data from the master branch."
Goto R&D Console.
See fucking 0 points.

Steps to reproduce

As above.

Length of time in which bug has been known to occur

Seen 04/02/2021, Mr Fox confirmed bug is something they've seen.

Client version, Server revision & Game ID

Server revision: master - 2021-02-04
7dc2aac

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of the issue being looked at sooner.

  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this
@zackerycodestoo
Copy link
Contributor

zackerycodestoo commented Feb 4, 2021 •
edited
Loading

This is likely connected to #73 -- it may have never been tested with cyborg uploads. Points are zeroed out to fix an exploit that appears to have been in Eris code.

The line I suspect is 345 in code/modules/research/rdconsole.dm:

files.research_points = 0 //Occulus edit. Fixes exploit

@Hawk-v3
Copy link
Contributor Author

Hawk-v3 commented Feb 4, 2021

image

There is no warning of this.

@zackerycodestoo zackerycodestoo added Bug Something isn't working as intended. ⚠️ Severity: S-3 Moderate Issue that will cause issues to gameplay, but aren't severe. 👥 Impact: I-5 Minimal (How many users is it expected to affect?) 0 - 1 ⚠️ Severity: S-1 Severe Large issues that will cause severe issues to gameplay and could fully interrupt gameplay. ⚠️ Severity: S-2 Major Issue that will cause issues to gameplay, and will hinder the player. and removed ⚠️ Severity: S-1 Severe Large issues that will cause severe issues to gameplay and could fully interrupt gameplay. ⚠️ Severity: S-3 Moderate Issue that will cause issues to gameplay, but aren't severe. labels Feb 9, 2021
@Jamini
Copy link
Member

Jamini commented Dec 1, 2021

#73 was never tested with cyborg uploads. We will need to refactor this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working as intended. 👥 Impact: I-5 Minimal (How many users is it expected to affect?) 0 - 1 ⚠️ Severity: S-2 Major Issue that will cause issues to gameplay, and will hinder the player.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hawk-v3 @Jamini @zackerycodestoo