Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gas transfer coefficients #168

Open
vtamsitt opened this issue Feb 28, 2024 · 3 comments
Open

Update gas transfer coefficients #168

vtamsitt opened this issue Feb 28, 2024 · 3 comments

Comments

@vtamsitt
Copy link

I'm interested in implementing updated gas transfer velocity (k) parameterisations (at the very least, Wanninkhof 1992 is outdated and could be replaced by Wanninkhof 2014). It would be great to add other gas transfer velocities e.g. Ho et al. 2006, as is mentioned in the code comments. I'm guessing the best way to implement this would be to add all of these parameterisations (and more?) and include a kwarg when calling GasExchange?

k(T, uₐᵥ, Sc_params) = 0.39 * (0.01 / 3600) * uₐᵥ ^ 2 * (Sc(T, Sc_params) / 660) ^ (-0.5)# m/s, may want to add variable wind speed instead of average wind here at some point

@johnryantaylor
Copy link
Collaborator

Hi @vtamsitt, thanks! That would be great and what you suggest seems like a good approach

@vtamsitt
Copy link
Author

vtamsitt commented Mar 4, 2024

Great, I'll work on this when I get a chance.

@glwagner
Copy link
Collaborator

glwagner commented Mar 5, 2024

It could make sense to add a property called transfer_velocity here:

then it'll be easy to add new models (for developers) or to switch between models (for users)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants