Serializing default property values is not required

Ocramius · Jun 13, 2014 · dcba7c6 · dcba7c6
1 parent 5554094
commit dcba7c6
Showing 1 changed file with 2 additions and 39 deletions.
diff --git a/src/Instantiator/Instantiator.php b/src/Instantiator/Instantiator.php
@@ -65,15 +65,11 @@ function () use ($reflectionClass) {
             $serializationFormat = 'C';
         }
 
-        $defaultValues = $this->getSerializedDefaultValues($reflectionClass);
-
         $serializedString = sprintf(
-            '%s:%d:"%s":%s:{%s}',
+            '%s:%d:"%s":0:{}',
             $serializationFormat,
             strlen($className),
-            $className,
-            count($defaultValues),
-            implode('', $defaultValues)
+            $className
         );
 
         return $this->storeAndExecuteInstantiator(
@@ -116,37 +112,4 @@ private function hasInternalAncestors(ReflectionClass $reflectionClass)
 
         return false;
     }
-
-    /**
-     * @param ReflectionClass $reflectionClass
-     *
-     * @return string[]
-     */
-    private function getSerializedDefaultValues(ReflectionClass $reflectionClass)
-    {
-        $properties = array();
-        $defaults   = $reflectionClass->getDefaultProperties();
-
-        do {
-            foreach ($reflectionClass->getProperties() as $property) {
-                if (! $property->getDeclaringClass()->getName() === $reflectionClass->getName()) {
-                    continue;
-                }
-
-                $visibility = 'public';
-
-                if ($property->isPrivate()) {
-                    $visibility = "\0" . $property->getDeclaringClass()->getName() . "\0private";
-                }
-
-                if ($property->isProtected()) {
-                    $visibility = "\0*\0protected";
-                }
-
-                $properties[] = serialize($visibility) . serialize($defaults[$property->getName()]);
-            }
-        } while ($reflectionClass = $reflectionClass->getParentClass());
-
-        return $properties;
-    }
 }