Correct current failures with psalm 3.6.2

[Ocramius]

See #513

The command "./vendor/bin/phpcs || true" exited with 0.

6.42s$ ./vendor/bin/psalm

ERROR: PossiblyNullReference - tests/ProxyManagerTest/ProxyGenerator/LazyLoadingValueHolder/PropertyGenerator/ValueHolderPropertyTest.php:39:89 - Cannot call method generate on possibly null value

            (new ValueHolderProperty(new ReflectionClass(self::class)))->getDocBlock()->generate()

ERROR: ArgumentTypeCoercion - tests/static-analysis/access-interceptor-scope-localizer.php:54:9 - Argument 2 of ProxyManager\Proxy\AccessInterceptorInterface::setMethodPrefixInterceptor expects Closure((InterceptedObjectType as object)&ProxyManager\Proxy\AccessInterceptorInterface=, StaticAnalysis\AccessInterceptorScopeLocalizer\MyProxiedClass=, string=, array<string, mixed>=, bool=):mixed|null, parent type Closure(StaticAnalysis\AccessInterceptorScopeLocalizer\MyProxiedClass&ProxyManager\Proxy\AccessInterceptorInterface, StaticAnalysis\AccessInterceptorScopeLocalizer\MyProxiedClass, string, array<string, mixed>, bool):mixed provided

        static function (

            object $proxy,

            MyProxiedClass $realInstance,

            string $method,

            array $parameters,

            bool & $returnEarly

        ) {

            echo 'pre-';

        }

ERROR: ArgumentTypeCoercion - tests/static-analysis/access-interceptor-value-holder.php:54:9 - Argument 2 of ProxyManager\Proxy\AccessInterceptorInterface::setMethodPrefixInterceptor expects Closure((InterceptedObjectType as object)&ProxyManager\Proxy\AccessInterceptorInterface=, StaticAnalysis\AccessInterceptorValueHolder\MyProxiedClass=, string=, array<string, mixed>=, bool=):mixed|null, parent type Closure(StaticAnalysis\AccessInterceptorValueHolder\MyProxiedClass&ProxyManager\Proxy\AccessInterceptorInterface, StaticAnalysis\AccessInterceptorValueHolder\MyProxiedClass, string, array<string, mixed>, bool):mixed provided

        static function (

            object $proxy,

            MyProxiedClass $realInstance,

            string $method,

            array $parameters,

            bool & $returnEarly

        ) {

            echo 'pre-';

        }

ERROR: MixedArgumentTypeCoercion - tests/static-analysis/lazy-loading-value-holder.php:59:39 - Argument 1 of ProxyManager\Proxy\VirtualProxyInterface::setProxyInitializer expects Closure(null|object=, (LazilyLoadedObjectType as object)&ProxyManager\Proxy\LazyLoadingInterface<LazilyLoadedObjectType>=, string=, array<string, mixed>=, Closure|null=, array<string, mixed>=):bool|null, parent type Closure(null|object, ProxyManager\Proxy\LazyLoadingInterface<object>, string, array<string, mixed>, Closure|null):true provided

    $valueHolder->setProxyInitializer(static function (

        ?object & $instance,

        LazyLoadingInterface $proxy,

        string $method,

        array $parameters,

        ?\Closure & $initializer

    ) : bool {

        $instance    = new MyProxiedClass();

        $initializer = null; // disable initialization

        return true;

    });

------------------------------

4 errors found

------------------------------

Checks took 6.00 seconds and used 296.357MB of memory

Psalm was able to infer types for 99.7845% of the codebase

The command "./vendor/bin/psalm" exited with 1.

[Ocramius]

Discussed directly with @muglug - some of these issues are solved in psalm master

[Ocramius]

Handled by #521