Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap project structure #25

Open
Daksh14 opened this issue Jan 29, 2021 · 4 comments
Open

Remap project structure #25

Daksh14 opened this issue Jan 29, 2021 · 4 comments
Labels
DT-is-easy This issue is easy to work on ST-help wanted Extra attention is needed T-enhancement New feature or request

Comments

@Daksh14
Copy link
Collaborator

Daksh14 commented Jan 29, 2021

Remapping project structure in the following way (suggestions always welcome)

octane_http1x
octane_http2
octane_http3
octane_multipart
octane_router
...

Basically, sub crates for each component, that way it's easy to hide them behind feature requests and code is in better and findable places

@Daksh14 Daksh14 added T-enhancement New feature or request ST-help wanted Extra attention is needed DT-is-easy This issue is easy to work on labels Jan 29, 2021
@somebody1234
Copy link

imo feature flags > subcrates; subcrates would only be better (instead of worse) if said crates could be used for other webservers as well

@Daksh14
Copy link
Collaborator Author

Daksh14 commented Jan 29, 2021

We would still have feature flags, it would be easier to separate protocols under feature flags with subcrates, they will both work together, also since we are a light weight web server, it would help, what do you say?

@somebody1234
Copy link

idk tbh. i guess my point is, if the subcrates can't be used alone there's no real reason to separate into subcrates

@Daksh14
Copy link
Collaborator Author

Daksh14 commented Jan 29, 2021

Good point, we'll defer on this for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DT-is-easy This issue is easy to work on ST-help wanted Extra attention is needed T-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants