Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BG image not ignored, make it a fallback image within assets #351

Closed
davidzwa opened this issue Mar 5, 2021 · 2 comments · Fixed by #375
Closed

BG image not ignored, make it a fallback image within assets #351

davidzwa opened this issue Mar 5, 2021 · 2 comments · Fixed by #375
Assignees
@davidzwa
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
1.1.13 - Pushup Party

Comments

@davidzwa
Copy link
Contributor

davidzwa commented Mar 5, 2021 •
edited

Client or Server side error
EJS

Describe the bug
Image can be changed, but then it becomes a git change as the file is still tracked.
Change image file and you'll see.

Solution
Make the image a fallback image with some smart index + EJS rendering logic.
@davidzwa davidzwa added the bug Something isn't working / good issue report label Mar 5, 2021
@NotExpectedYet NotExpectedYet self-assigned this Mar 5, 2021
@NotExpectedYet
Copy link
Member

One for 1.1.13 :)

Will investigate a graceful way as currently is sat in CSS hard coded I believe.

@davidzwa
Copy link
Contributor Author

davidzwa commented Mar 5, 2021

Point the URL to a route and figure it out in ExpressJS :)

@davidzwa davidzwa assigned davidzwa and unassigned NotExpectedYet Mar 12, 2021
@davidzwa davidzwa linked a pull request Mar 17, 2021 that will close this issue
Ignore background image and copy a default if not present #375
Merged
@davidzwa davidzwa moved this from To do to Done in 1.1.13 - Pushup Party Mar 17, 2021
@davidzwa davidzwa added the fixed on dev This issue has been fixed and is on its way label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidzwa davidzwa

Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
No open projects
1.1.13 - Pushup Party
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore background image and copy a default if not present OctoFarm/OctoFarm
2 participants
@davidzwa @NotExpectedYet