Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config/db.js + migration + fully test #373

Closed
davidzwa opened this issue Mar 17, 2021 · 3 comments · Fixed by #435
Closed

Remove config/db.js + migration + fully test #373

davidzwa opened this issue Mar 17, 2021 · 3 comments · Fixed by #435
Assignees
Labels
feature request Triage for a new feature fixed on dev This issue has been fixed and is on its way

Comments

@davidzwa
Copy link
Contributor

davidzwa commented Mar 17, 2021

Server

  • Update migration script from 1.1.x to 1.1.13 to create .env file if it does not exist with latest MONGO=${MongoUri}
  • Startup script to create .env if not exists and not in docker mode (using the same function as in the migration script, but now without db.js as source and default MONGO conn string without authentication) + test mongo after + warn if conn fails
  • Fix startup mongo conn test not dealing with auth error correctly
  • Add warning/console instructions about new environment variable requiring MONGO to be defined, abort if it is not defined
  • Remove db.js file from repo
  • Regression Test: .env with MONGO in it created and found at all times for non-docker (do this in test folder + gitignore the resulting .env at that place)
  • Test migration script: .env with MONGO in it created and equal to our default string in config/db.js (hardcoded)
  • Regression Test2: .env with custom (f.e. auth) MONGO in it created when this is known as environment var (and env file didnt exist before)
  • Regression Test3: .env with valid MONGO not updated when the environment var is different before merging with dotenv
@davidzwa davidzwa added the feature request Triage for a new feature label Mar 17, 2021
@davidzwa davidzwa self-assigned this Mar 17, 2021
@davidzwa davidzwa added this to To do in 1.1.13 - Pushup Party via automation Mar 17, 2021
@davidzwa davidzwa changed the title Remove config/db.js Remove config/db.js + migration + properly test Mar 17, 2021
@davidzwa davidzwa changed the title Remove config/db.js + migration + properly test Remove config/db.js + migration + fully test Mar 17, 2021
@NotExpectedYet
Copy link
Member

We could do the same for Port here?

@davidzwa
Copy link
Contributor Author

Love it! Will mark a separate issue and add similar validation/migration scripts.

@NotExpectedYet
Copy link
Member

Love it! Will mark a separate issue and add similar validation/migration scripts.
Epic! I think the UI option can go bye bye as well personally.

@davidzwa davidzwa moved this from To do to In progress in 1.1.13 - Pushup Party Apr 14, 2021
@davidzwa davidzwa linked a pull request Apr 16, 2021 that will close this issue
13 tasks
@davidzwa davidzwa added the fixed on dev This issue has been fixed and is on its way label Apr 20, 2021
@davidzwa davidzwa moved this from In progress to Awaiting Review in 1.1.13 - Pushup Party Apr 22, 2021
@NotExpectedYet NotExpectedYet moved this from Awaiting Review to Done in 1.1.13 - Pushup Party Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Triage for a new feature fixed on dev This issue has been fixed and is on its way
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants