Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User and group middleware #430

Closed
davidzwa opened this issue Apr 11, 2021 · 1 comment
Closed

User and group middleware #430

davidzwa opened this issue Apr 11, 2021 · 1 comment
Assignees
Labels
feature request Triage for a new feature fixed on dev This issue has been fixed and is on its way

Comments

@davidzwa
Copy link
Contributor

Server

let user = null;
let group = null;
if (serverSettings.server.loginRequired === false) {
  user = "No User";
  group = "Administrator";
} else {
  user = req.user.name;
  group = req.user.group;
}

Replace with middleware or a intercepter/guard so we dont have to repeat this code. Ever.

@davidzwa davidzwa added feature request Triage for a new feature effort-20 labels Apr 11, 2021
@NotExpectedYet
Copy link
Member

Yes!

@davidzwa davidzwa self-assigned this Apr 14, 2021
@NotExpectedYet NotExpectedYet added the fixed on dev This issue has been fixed and is on its way label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Triage for a new feature fixed on dev This issue has been fixed and is on its way
Projects
None yet
Development

No branches or pull requests

2 participants