Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npm check and installation for updater #444

Closed
NotExpectedYet opened this issue Apr 23, 2021 · 0 comments
Closed

Npm check and installation for updater #444

NotExpectedYet opened this issue Apr 23, 2021 · 0 comments
Assignees
@NotExpectedYet
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
1.1.13 - Pushup Party

Comments

@NotExpectedYet
Copy link
Member

Updater doesn't currently care about deps, these could change/be added. For now I think it suffices to put a check inplace for missing deps and install the newer ones. npm ci is too destructive and should only be for initial installation due to file locks and such
@NotExpectedYet NotExpectedYet added the bug Something isn't working / good issue report label Apr 23, 2021
@NotExpectedYet NotExpectedYet self-assigned this Apr 23, 2021
@NotExpectedYet NotExpectedYet added this to In progress in 1.1.13 - Pushup Party Apr 23, 2021
@NotExpectedYet NotExpectedYet moved this from In progress to Done in 1.1.13 - Pushup Party Apr 23, 2021
@NotExpectedYet NotExpectedYet added the fixed on dev This issue has been fixed and is on its way label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NotExpectedYet NotExpectedYet

Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
No open projects
1.1.13 - Pushup Party
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NotExpectedYet