Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort if less than Node 14 (f.e. 10 or 12) #478

Closed
davidzwa opened this issue Apr 25, 2021 · 3 comments · Fixed by #487
Closed

Abort if less than Node 14 (f.e. 10 or 12) #478

davidzwa opened this issue Apr 25, 2021 · 3 comments · Fixed by #487
Assignees
@davidzwa
Labels
bug Something isn't working / good issue report
Projects
1.1.13 - Pushup Party

Comments

@davidzwa
Copy link
Contributor

Add code which can compile in Node 12 to abort an OctoFarm installation in Node <14.
Had gm reporting the '?' operator failing for earlier node version in pm2 but it repeatedly continues
@davidzwa davidzwa added bug Something isn't working / good issue report effort-5 labels Apr 25, 2021
@davidzwa davidzwa self-assigned this Apr 25, 2021
@NotExpectedYet
Copy link
Member

Engines strict is no longer working that's why.

Apparently it needs to be in npmrc file now. Will research more.

@davidzwa
Copy link
Contributor Author

Ah and I guess continuous pm2 restarting is only temporary

@NotExpectedYet
Copy link
Member

Ah and I guess continuous pm2 restarting is only temporary

Think we need to add a --restart-delay for that one

https://pm2.keymetrics.io/docs/usage/restart-strategies/

@davidzwa davidzwa changed the title Abort if Node 12 Abort if less than Node 14 (f.e. 10 or 12) Apr 26, 2021
@davidzwa davidzwa moved this from To do to Awaiting Review in 1.1.13 - Pushup Party Apr 27, 2021
@NotExpectedYet NotExpectedYet moved this from Awaiting Review to Done in 1.1.13 - Pushup Party Apr 27, 2021
@davidzwa davidzwa linked a pull request Apr 27, 2021 that will close this issue
Node12 friendly abort #487
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidzwa davidzwa

Labels
bug Something isn't working / good issue report
Projects
No open projects
1.1.13 - Pushup Party
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node12 friendly abort OctoFarm/OctoFarm
2 participants
@davidzwa @NotExpectedYet