Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OctoPrint port setting - actual saved value could be checked against available ports #531

Closed
davidzwa opened this issue May 2, 2021 · 1 comment · Fixed by #545
Closed

OctoPrint port setting - actual saved value could be checked against available ports #531

davidzwa opened this issue May 2, 2021 · 1 comment · Fixed by #545
Labels
feature request Triage for a new feature fixed on dev This issue has been fixed and is on its way
Projects
1.2 - Patreon Payback and the Great C...

Comments

@davidzwa
Copy link
Contributor

davidzwa commented May 2, 2021

  • Description
    The setting for port is not checked, which could give OF information about what is saved in OP and what can be done to fix it for a user.

  • Repro
    Go to a printer settings dialog and check the port is empty because the port is not listed.
@davidzwa davidzwa added bug Something isn't working / good issue report feature request Triage for a new feature and removed bug Something isn't working / good issue report labels May 2, 2021
@davidzwa davidzwa changed the title OctoPrint port setting - actual saved value not checked OctoPrint port setting - actual saved value could be checked against available ports May 2, 2021
@NotExpectedYet NotExpectedYet mentioned this issue May 3, 2021
Merged
20 tasks
@NotExpectedYet NotExpectedYet linked a pull request May 3, 2021 that will close this issue
Feature/printer settings dialog improvements #545
Merged
20 tasks
@davidzwa davidzwa added the fixed on dev This issue has been fixed and is on its way label May 9, 2021
@davidzwa davidzwa moved this from In progress to Done in 1.2 - Patreon Payback and the Great Cleanup Jun 10, 2021
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

This issue has been marked as stale... It will be closed in 5 days unless commented on.

@github-actions github-actions bot added the stale Any issue which has expired but still has value label Jul 9, 2021
@davidzwa davidzwa removed the stale Any issue which has expired but still has value label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Triage for a new feature fixed on dev This issue has been fixed and is on its way
Projects
No open projects
1.2 - Patreon Payback and the Great C...
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/printer settings dialog improvements OctoFarm/OctoFarm
2 participants
@davidzwa @NotExpectedYet