Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filament / History Graphs stay "loading..." when no data presented if outside 30 day window. #538

Closed
NotExpectedYet opened this issue May 2, 2021 · 12 comments
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way stale Any issue which has expired but still has value

Comments

@NotExpectedYet
Copy link
Member

Description of the problem

Not real dire, as depends how active someones farm is. Data is outside of 30 day window graphs still show "loading..."

Reproduction of the problem

Go to graphs without that data in a 30 day window.
@NotExpectedYet NotExpectedYet added the bug Something isn't working / good issue report label May 2, 2021
@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This issue has been marked as stale... It will be closed in 5 days unless commented on.

@github-actions github-actions bot added the stale Any issue which has expired but still has value label Jul 2, 2021
@NotExpectedYet
Copy link
Member Author

@davidzwa this was fixed no?

@davidzwa
Copy link
Contributor

davidzwa commented Jul 2, 2021

I dont think it is. I was mainly busy with the data inside the 30 day interval. You were able to spot this bug outside it and I dont recall us fixing it

@NotExpectedYet
Copy link
Member Author

I dont think it is. I was mainly busy with the data inside the 30 day interval. You were able to spot this bug outside it and I dont recall us fixing it

I'll double check.

@github-actions github-actions bot removed the stale Any issue which has expired but still has value label Jul 3, 2021
@NotExpectedYet
Copy link
Member Author

image

Yeah fixed, well outside the 30 day window

@NotExpectedYet NotExpectedYet added the fixed on dev This issue has been fixed and is on its way label Jul 3, 2021
@davidzwa
Copy link
Contributor

davidzwa commented Jul 3, 2021

Uhh or 90? Not sure right now

@NotExpectedYet
Copy link
Member Author

Uhh or 90? Not sure right now

Is it still 90?

that's from dashboard, was taking it on face value you updated the variable name in the re-factor. If that's not the case then could still be a bug xD

image

@NotExpectedYet
Copy link
Member Author

Think the dashboard charts need a check over. Get this when enabling the bottom ones.

image

@davidzwa
Copy link
Contributor

davidzwa commented Jul 3, 2021

Yeah it was hard for me to test them. Rushed it a bit.

Oh btw: Im so confused right now hahaha

@NotExpectedYet
Copy link
Member Author

NotExpectedYet commented Jul 3, 2021

We have errors now though! 😁 (Webpack)

@NotExpectedYet
Copy link
Member Author

image

Yep still brokey, need's to use the actual date ranges that are created, not -90 days haha.

@github-actions
Copy link

This issue has been marked as stale... It will be closed in 5 days unless commented on.

@github-actions github-actions bot added the stale Any issue which has expired but still has value label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way stale Any issue which has expired but still has value
Projects
No open projects
Development

No branches or pull requests

2 participants