Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new port preference availability check to Printer Manager modal. #562

Closed
NotExpectedYet opened this issue May 9, 2021 · 0 comments · Fixed by #545
Closed

Add new port preference availability check to Printer Manager modal. #562

NotExpectedYet opened this issue May 9, 2021 · 0 comments · Fixed by #545
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way

Comments

@NotExpectedYet
Copy link
Member

Description of the problem

Currently it's only the settings that check for the port preference availability. This check needs adding into the Printer Manager Modal too.

I believe it would also be beneficial to disable the connect button, as that's going to fail anyway we might as well not allow it.

Reproduction of the problem

Open Printer Settings with printer offline (not in port list), see the new check.
Open Printer Manager with printer offline (not in port list), aww no check!
@NotExpectedYet NotExpectedYet added the bug Something isn't working / good issue report label May 9, 2021
@davidzwa davidzwa added the fixed on dev This issue has been fixed and is on its way label May 30, 2021
@davidzwa davidzwa linked a pull request May 30, 2021 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working / good issue report fixed on dev This issue has been fixed and is on its way
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants