Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warning - default behavior of is_blueprint_csrf_protected will change #327

Closed
draeath opened this issue Sep 30, 2022 · 3 comments

Comments

@draeath
Copy link

draeath commented Sep 30, 2022

Hardware Setup
N/A

Describe the problem
Deprecation warning in octoprint_out.log indicates something needs to be changed prior to a future octoprint release.

Log Files

2022-09-30 01:00:38,718 - octoprint.plugins.firmwareupdater - WARNING - The Blueprint of this plugin is relying on the default implementation of is_blueprint_csrf_protected (newly added in OctoPrint 1.8.3), which in a future version will be switched from False to True for security reasons. Plugin authors should ensure they explicitly declare the CSRF protection status in their BlueprintPlugin mixin implementation. Recommendation is to enable CSRF protection and exempt views that must not use it with the octoprint.plugin.BlueprintPlugin.csrf_exempt decorator.
2022-09-30 01:00:38,718 - octoprint.server - WARNING - CSRF Protection for Blueprint of plugin firmwareupdater is DISABLED

Additional context
OctoPrint version 1.8.4
Plugin version 6e1fb6d (master branch, 2022-09-30)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any recent activity. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed in 5 days.

@benlye
Copy link
Collaborator

benlye commented Nov 10, 2022

Will be addressed in 1.14.0 (available in the devel branch for testing now).

@benlye benlye closed this as completed Mar 20, 2023
@github-actions
Copy link

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants