Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override limit changed after 3.9 #271

Closed
klas opened this issue Sep 21, 2016 · 4 comments
Closed

Ability to override limit changed after 3.9 #271

klas opened this issue Sep 21, 2016 · 4 comments

Comments

@klas
Copy link
Collaborator

klas commented Sep 21, 2016

Before 3.9 it was possible to override limit parameter to show number of items within this limit. Now this doesn't work anymore as pagination value is always applied.

I suspect this is the cause
ef62ac4

@klas
Copy link
Collaborator Author

klas commented Sep 21, 2016

More info: it now only works with with Native setting in pagination and works as "pagination page size", otherwise it is just discarded. Before it worked regardless of what pagination setting was - as an override.

Is there any reason behind this change? Unless it would break something else I would suggest to restore previous behavior.

@klas klas changed the title Ability to override limit broken after 3.9 Ability to override limit changed after 3.9 Sep 21, 2016
@klas
Copy link
Collaborator Author

klas commented Sep 23, 2016

@klas
Copy link
Collaborator Author

klas commented Dec 27, 2016

Related (fixed?) af645c3

@sebastienheraud
Copy link
Member

Hi Klas,

I'm closing this one as overriding the "limit" was never a feature, even if it happened to work on older versions.

With SEBLOD 3.17.2+ (and the latest version of Search Pagination plug-in) it is now possible to let end-users interact with the limit/pagination on the fly.

cf https://www.seblod.com/changelogs#SEBLOD_3172_20190131

Saba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants